Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2686843002:
Add more seed corpus for blink_png_decoder_fuzzer. (Closed)
DescriptionAdd more as seed corpus for blink_png_decoder_fuzzer.
Add corpus //WebKit/LayoutTests/images/png-suite/samples and
//cc/test/data
R=noel@chromium.org, scroggo@chromium.org
BUG=437662, 678181
Review-Url: https://codereview.chromium.org/2686843002
Cr-Commit-Position: refs/heads/master@{#449287}
Committed: https://chromium.googlesource.com/chromium/src/+/9f178059a3f0fd6f7a151bfe129a697ceaf0b150
Patch Set 1 #Patch Set 2 : Add samples from png-suite + rebase #Patch Set 3 : Rebase #Messages
Total messages: 21 (9 generated)
On 2017/02/08 17:09:40, mmoroz wrote: As we've discussed some time ago in https://codereview.chromium.org/2578263002/diff/20001/third_party/WebKit/Sour... :)
lgtm
lgtm
On 2017/02/08 23:21:15, noel gordon wrote: > lgtm One question before we go ahead. The images from cc are probably not that interesting since they look to be basic PNG images from a screen-shot. I think the images in src/chrome/src/third_party/WebKit/LayoutTests/images/png-suite/samples have many different types of PNG (basic, indexed, progressive, and so on). We should maybe consider adding those?
On 2017/02/09 00:23:56, noel gordon wrote: > On 2017/02/08 23:21:15, noel gordon wrote: > > lgtm > > One question before we go ahead. The images from cc are probably not that > interesting since they look to be basic PNG images from a screen-shot. I think > the images in > > src/chrome/src/third_party/WebKit/LayoutTests/images/png-suite/samples > > have many different types of PNG (basic, indexed, progressive, and so on). We > should maybe consider adding those? Oh that's a great idea! I've added this directory as well. Thanks for the suggestion, I'll update another PNG fuzzer with this path also.
Description was changed from ========== Add "//cc/test/data" as seed corpus for blink_png_decoder_fuzzer. R=noel@chromium.org, scroggo@chromium.org BUG=437662,678181 ========== to ========== Add more as seed corpus for blink_png_decoder_fuzzer. R=noel@chromium.org, scroggo@chromium.org BUG=437662,678181 ==========
The CQ bit was checked by mmoroz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@chromium.org, noel@chromium.org Link to the patchset: https://codereview.chromium.org/2686843002/#ps20001 (title: "Add samples from png-suite + rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
On 2017/02/09 09:49:00, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, > https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) > android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, > https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) Got it. Should be fixed by https://codereview.chromium.org/2685843006/. Then I'll rebase this CL and land it as well.
Description was changed from ========== Add more as seed corpus for blink_png_decoder_fuzzer. R=noel@chromium.org, scroggo@chromium.org BUG=437662,678181 ========== to ========== Add more as seed corpus for blink_png_decoder_fuzzer. Add corpus //WebKit/LayoutTests/images/png-suite/samples and //cc/test/data R=noel@chromium.org, scroggo@chromium.org BUG=437662,678181 ==========
On 2017/02/09 11:04:30, mmoroz wrote: > Got it. Should be fixed by https://codereview.chromium.org/2685843006/. Then > I'll rebase this CL and land it as well. OK thanks, still LGTM.
The CQ bit was checked by mmoroz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@chromium.org, noel@chromium.org Link to the patchset: https://codereview.chromium.org/2686843002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486642999950010,
"parent_rev": "73f7308734f2a4d775190e1a3e83b95da8cc5a3c", "commit_rev":
"9f178059a3f0fd6f7a151bfe129a697ceaf0b150"}
Message was sent while issue was closed.
Description was changed from ========== Add more as seed corpus for blink_png_decoder_fuzzer. Add corpus //WebKit/LayoutTests/images/png-suite/samples and //cc/test/data R=noel@chromium.org, scroggo@chromium.org BUG=437662,678181 ========== to ========== Add more as seed corpus for blink_png_decoder_fuzzer. Add corpus //WebKit/LayoutTests/images/png-suite/samples and //cc/test/data R=noel@chromium.org, scroggo@chromium.org BUG=437662,678181 Review-Url: https://codereview.chromium.org/2686843002 Cr-Commit-Position: refs/heads/master@{#449287} Committed: https://chromium.googlesource.com/chromium/src/+/9f178059a3f0fd6f7a151bfe129a... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/9f178059a3f0fd6f7a151bfe129a... |
