Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issue 2686793002: DOM: Do not skip 'replace data' operation on setting identical string to CharacterData. (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DOM: Do not skip 'replace data' operation on setting identical string to CharacterData. According to the standard, we should not skip to replace the data. https://dom.spec.whatwg.org/#dom-characterdata-data https://dom.spec.whatwg.org/#concept-cd-replace The new behavior matches to Edge, Firefox and Safari. This CL might affect micro benchmarks, but it's expected. BUG=689807 Review-Url: https://codereview.chromium.org/2686793002 Cr-Commit-Position: refs/heads/master@{#448921} Committed: https://chromium.googlesource.com/chromium/src/+/d44dd6aa2f437590e4fb52bce5f5887f78548a83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+451 lines, -454 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/dom/ranges/Range-mutations-dataChange-expected.txt View 195 chunks +450 lines, -450 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLElement/set-inner-outer-optimization.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/CharacterData.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
tkent
yoichio@ or yosin@, would you review this please?
3 years, 10 months ago (2017-02-08 06:06:38 UTC) #6
yosin_UTC9
lgtm Thanks for improving interchangeability!
3 years, 10 months ago (2017-02-08 06:13:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686793002/1
3 years, 10 months ago (2017-02-08 06:13:28 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 06:30:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d44dd6aa2f437590e4fb52bce5f5...

Powered by Google App Engine
This is Rietveld 408576698