chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc - Issue 268673007: Extracting page shingle hashes for similarity detection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

Issue 268673007: Extracting page shingle hashes for similarity detection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address 1st round comment Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/safe_browsing/csd.proto ('K') | « chrome/renderer/safe_browsing/phishing_classifier.cc ('k') | chrome/renderer/safe_browsing/phishing_term_feature_extractor.h » ('j') | chrome/renderer/safe_browsing/phishing_term_feature_extractor.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

diff --git a/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc b/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

index 19adce43264f8ae899767f957e69bb840e0ab9a6..d8918ced1b6b8cf98aec4b506254d1be02fe8476 100644

--- a/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

+++ b/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

@@ -93,6 +93,8 @@ class PhishingClassifierTest : public InProcessBrowserTest {

model.set_murmur_hash_seed(2777808611U);

model.add_page_word(MurmurHash3String("login", model.murmur_hash_seed()));

model.set_max_words_per_term(1);

+ model.set_max_shingles_per_page(200);

noelutz 2014/05/06 21:40:18 Is this necessary since you're setting these as de

zysxqn 2014/05/07 19:29:19 Prefer to set a non-default value than removing it

+ model.set_shingle_size(4);

clock_ = new MockFeatureExtractorClock;

scorer_.reset(Scorer::Create(model.SerializeAsString()));