chrome/common/safe_browsing/csd.proto - Issue 268673007: Extracting page shingle hashes for similarity detection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/safe_browsing/csd.proto

Issue 268673007: Extracting page shingle hashes for similarity detection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address 1st round comment Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/safe_browsing/client_model.proto ('K') | « chrome/common/safe_browsing/client_model.proto ('k') | chrome/renderer/safe_browsing/phishing_classifier.h » ('j') | chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/safe_browsing/csd.proto

diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto

index 6b5f6c6f6d3c080b7b8910a4fafca55ce2948999..8de884c180608ff609b43b80dae27e761958e69d 100644

--- a/chrome/common/safe_browsing/csd.proto

+++ b/chrome/common/safe_browsing/csd.proto

@@ -68,6 +68,9 @@ message ClientPhishingRequest {

optional string OBSOLETE_referrer_url = 9;

// Field 11 is only used on the server.

+ // List of shingle hashes we extracted.

+ repeated uint32 shingle_hashes = 12;

noelutz 2014/05/06 21:40:18 don't forget to mark these as packed as well. Oth

zysxqn 2014/05/07 19:29:19 Done.

}

message ClientPhishingResponse {