Move bookmarks' test support file to the bookmarks component

Move bookmarks' test support file to the bookmarks component

Those files are used by a lot of tests and do not depends on chrome/
or content/ so they can be moved to the component in a new library
that will be used by the test (eventually components_unittests).

BUG=367839
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268282

[sdefresne, 2014-05-01 15:32:30]

Please have a look.

Note that this depends on https://codereview.chromium.org/257003004/ and will
only be submitted once the other CL has been submitted (try bots may also fail
until the other CL is submitted).

[tfarina, 2014-05-01 15:36:55]

Please, name the directory test rather than tests. Since the former is much more
common. Some examples: ash/test, cc/test, content/public/test, ui/base/test.

Thanks,

[sky, 2014-05-01 19:15:03]

https://codereview.chromium.org/268673004/diff/20001/components/bookmarks.gypi
File components/bookmarks.gypi (right):

https://codereview.chromium.org/268673004/diff/20001/components/bookmarks.gyp...
components/bookmarks.gypi:86: 'target_name': 'bookmarks_core_tests',
bookmarks_core_test_support

[sdefresne, 2014-05-05 14:12:33]

PTAL

https://codereview.chromium.org/268673004/diff/20001/components/bookmarks.gypi
File components/bookmarks.gypi (right):

https://codereview.chromium.org/268673004/diff/20001/components/bookmarks.gyp...
components/bookmarks.gypi:86: 'target_name': 'bookmarks_core_tests',
On 2014/05/01 19:15:04, sky wrote:
> bookmarks_core_test_support

Done.

[sky, 2014-05-05 14:30:24]

LGTM

[tfarina, 2014-05-05 15:51:42]

lgtm

https://codereview.chromium.org/268673004/diff/40001/chrome/chrome_tests_unit...
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/268673004/diff/40001/chrome/chrome_tests_unit...
chrome/chrome_tests_unit.gypi:24:
'../components/components.gyp:sync_driver_test_support',
while you are here, remove this duplicated entry.

[sdefresne, 2014-05-05 17:52:23]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-05-05 17:53:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sdefresne@chromium.org/268673004/60001

[commit-bot: I haz the power, 2014-05-05 21:53:51]

Change committed as 268282

[blundell, 2014-05-06 09:24:44]

A couple of after-the-fact comments.

https://codereview.chromium.org/268673004/diff/60001/components/bookmarks/cor...
File components/bookmarks/core/test/bookmark_test_helpers.h (left):

https://codereview.chromium.org/268673004/diff/60001/components/bookmarks/cor...
components/bookmarks/core/test/bookmark_test_helpers.h:13: namespace test {
These can just be in the bookmarks namespace once you move all the component
code to being in the bookmarks namespace.

https://codereview.chromium.org/268673004/diff/60001/components/bookmarks/cor...
File components/bookmarks/core/test/bookmark_test_helpers.h (right):

https://codereview.chromium.org/268673004/diff/60001/components/bookmarks/cor...
components/bookmarks/core/test/bookmark_test_helpers.h:5: #ifndef
COMPONENTS_BOOKMARKS_CORE_TEST_BOOKMARK_TEST_HELPERS_H_
For components, we've typically put the test support code next to the production
code, i.e., in //components/bookmarks/core/browser in this case. I don't see a
reason to deviate from that here.