chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc - Issue 268673004: Move bookmarks' test support file to the bookmarks component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

Issue 268673004: Move bookmarks' test support file to the bookmarks component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@367839

Patch Set: Remove duplicated dependency Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browser_commands_unittest.cc ('k') | chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc » ('j') | components/bookmarks/core/test/bookmark_test_helpers.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

index 726bfe1363c20701ef5f76a292b880539e649fa5..ba2527de96942fdec296f22681836f9757f9ab5b 100644

--- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

+++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

@@ -8,12 +8,12 @@

#include "base/prefs/pref_service.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/bookmarks/bookmark_model_factory.h"

-#include "chrome/browser/bookmarks/bookmark_test_helpers.h"

#include "chrome/browser/extensions/extension_apitest.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/common/pref_names.h"

#include "components/bookmarks/core/browser/bookmark_model.h"

+#include "components/bookmarks/core/test/bookmark_test_helpers.h"

#include "components/user_prefs/user_prefs.h"

// Times out on win syzyasan, http://crbug.com/166026