Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2686703002: Remove TrayPopupLabelButton (a pre-MD class) and its assets. (Closed)

Created:
3 years, 10 months ago by Evan Stade
Modified:
3 years, 10 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, sadrul, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove TrayPopupLabelButton (a pre-MD class) and its assets. This also tears out some pre-MD code from other files, but I tried to limit that to the minimum required to remove this button class. BUG=686261, 686251 Review-Url: https://codereview.chromium.org/2686703002 Cr-Commit-Position: refs/heads/master@{#448876} Committed: https://chromium.googlesource.com/chromium/src/+/62ff72d4604ce4bb6f7f612d8ca02436e098695e

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -677 lines) Patch
M ash/BUILD.gn View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ash/common/system/chromeos/network/network_state_list_detailed_view.h View 4 chunks +0 lines, -16 lines 0 comments Download
M ash/common/system/chromeos/network/network_state_list_detailed_view.cc View 1 9 chunks +30 lines, -330 lines 0 comments Download
M ash/common/system/chromeos/network/tray_vpn.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/chromeos/network/vpn_list_view.cc View 1 6 chunks +16 lines, -109 lines 0 comments Download
M ash/common/system/chromeos/screen_security/screen_tray_item.h View 1 chunk +0 lines, -1 line 0 comments Download
D ash/common/system/tray/tray_popup_label_button.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ash/common/system/tray/tray_popup_label_button.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D ash/common/system/tray/tray_popup_label_button_border.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ash/common/system/tray/tray_popup_label_button_border.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M ash/common/system/tray/tray_popup_utils.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/system/tray_accessibility.cc View 2 chunks +0 lines, -28 lines 0 comments Download
M ash/common/system/user/user_view.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
D ash/resources/default_100_percent/common/tray_popup_label_button_border.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/tray_popup_label_button_hover_background.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/tray_popup_label_button_normal_background.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/tray_popup_label_button_border.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/tray_popup_label_button_hover_background.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/tray_popup_label_button_normal_background.png View Binary file 0 comments Download

Messages

Total messages: 14 (9 generated)
Evan Stade
3 years, 10 months ago (2017-02-07 22:23:09 UTC) #3
tdanderson
LGTM with one comment https://codereview.chromium.org/2686703002/diff/1/ash/common/system/chromeos/network/vpn_list_view.cc File ash/common/system/chromeos/network/vpn_list_view.cc (right): https://codereview.chromium.org/2686703002/diff/1/ash/common/system/chromeos/network/vpn_list_view.cc#newcode215 ash/common/system/chromeos/network/vpn_list_view.cc:215: if (UseMd()) { Remove this ...
3 years, 10 months ago (2017-02-08 00:39:37 UTC) #7
Evan Stade
https://codereview.chromium.org/2686703002/diff/1/ash/common/system/chromeos/network/vpn_list_view.cc File ash/common/system/chromeos/network/vpn_list_view.cc (right): https://codereview.chromium.org/2686703002/diff/1/ash/common/system/chromeos/network/vpn_list_view.cc#newcode215 ash/common/system/chromeos/network/vpn_list_view.cc:215: if (UseMd()) { On 2017/02/08 00:39:37, tdanderson wrote: > ...
3 years, 10 months ago (2017-02-08 01:00:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686703002/20001
3 years, 10 months ago (2017-02-08 01:00:48 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 02:53:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/62ff72d4604ce4bb6f7f612d8ca0...

Powered by Google App Engine
This is Rietveld 408576698