Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2686683002: Deprecate most of gaia_auth extension (Closed)

Created:
3 years, 10 months ago by xiyuan
Modified:
3 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate most of gaia_auth extension - Reduce gaia_auth extension to just serve success landing page; - Move channel.js and saml_injected to gaia_auth_host; - new_inline_login.html -> inline_login.html; - Remove unused member from GaiaAuthExtensionLoader; BUG=688565 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2686683002 Cr-Commit-Position: refs/heads/master@{#449349} Committed: https://chromium.googlesource.com/chromium/src/+/d9c901b89a037d1fe9e44bf2f203400c1f51f444

Patch Set 1 #

Patch Set 2 : remove unused data member from GaiaAuthExtensionLoader #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1928 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/signin/gaia_auth_extension_loader.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/signin/gaia_auth_extension_loader.cc View 1 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/browser/resources/gaia_auth/background.js View 1 chunk +0 lines, -463 lines 0 comments Download
D chrome/browser/resources/gaia_auth/channel.js View 1 chunk +0 lines, -121 lines 0 comments Download
D chrome/browser/resources/gaia_auth/main.css View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/resources/gaia_auth/main.html View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/browser/resources/gaia_auth/main.js View 1 chunk +0 lines, -553 lines 0 comments Download
M chrome/browser/resources/gaia_auth/manifest.json View 1 chunk +1 line, -28 lines 0 comments Download
D chrome/browser/resources/gaia_auth/offline.css View 1 chunk +0 lines, -282 lines 0 comments Download
D chrome/browser/resources/gaia_auth/offline.html View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/resources/gaia_auth/offline.js View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/resources/gaia_auth/saml_injected.js View 1 chunk +0 lines, -218 lines 0 comments Download
D chrome/browser/resources/gaia_auth/util.js View 1 chunk +0 lines, -49 lines 0 comments Download
A + chrome/browser/resources/gaia_auth_host/channel.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/gaia_auth_host/post_message_channel.js View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/gaia_auth_host/saml_injected.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/gaia_auth_host/webview_saml_injected.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/inline_login/inline_login.html View 2 chunks +5 lines, -2 lines 0 comments Download
D chrome/browser/resources/inline_login/new_inline_login.html View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
xiyuan
achuith@: everything rogerta@: new_inline_login.html -> inline_login.html renaming and c/b/ui/webui/signin/inline_login_ui.cc Thanks.
3 years, 10 months ago (2017-02-07 22:38:40 UTC) #7
achuithb
Thanks for the cleanup. lgtm
3 years, 10 months ago (2017-02-07 22:47:18 UTC) #8
Roger Tawa OOO till Jul 10th
lgtm Nice cleanup Xiyuan! Note I'm not on the sign in team anymore so adding ...
3 years, 10 months ago (2017-02-08 16:43:24 UTC) #9
xiyuan
+msarda Thanks Roger. Adding Mihai in case he has something to say.
3 years, 10 months ago (2017-02-08 17:08:31 UTC) #11
msarda
lgtm
3 years, 10 months ago (2017-02-09 15:53:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686683002/20001
3 years, 10 months ago (2017-02-09 17:03:50 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 18:09:38 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d9c901b89a037d1fe9e44bf2f203...

Powered by Google App Engine
This is Rietveld 408576698