Initial fuzzer for SpdySession

Initial fuzzer for SpdySession

This is pretty limited in what it covers since it doesn't
attempt to request other streams and the like; felt like
the minimum reviewable version.

BUG=688004
Review-Url: https://codereview.chromium.org/2686673003
Cr-Commit-Position: refs/heads/master@{#449636}
Committed: https://chromium.googlesource.com/chromium/src/+/833190ec3fb8c4dd2d66e1b5b2ed3cf34a70f609

[Maks Orlovich, 2017-02-08 19:32:56]

The CQ bit was checked by morlovich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 19:34:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Maks Orlovich, 2017-02-08 20:30:02]

morlovich@chromium.org changed reviewers:
+ bnc@chromium.org

[Maks Orlovich, 2017-02-08 20:30:02]

Please note that this is in no way time sensitive --- I need to switch back to
some mod_pagespeed stuff anyway --- just it's at a point where I thing feedback
is needed, so if you have some spare cycle it would be appreciated.

[commit-bot: I haz the power, 2017-02-08 21:01:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 21:01:02]

Dry run: This issue passed the CQ dry run.

[mmoroz, 2017-02-09 08:21:00]

mmoroz@chromium.org changed reviewers:
+ mmoroz@chromium.org

[mmoroz, 2017-02-09 08:21:01]

https://codereview.chromium.org/2686673003/diff/1/net/spdy/spdy_session_fuzze...
File net/spdy/spdy_session_fuzzer.cc (right):

https://codereview.chromium.org/2686673003/diff/1/net/spdy/spdy_session_fuzze...
net/spdy/spdy_session_fuzzer.cc:62: int rv = stream_request.StartRequest(
Does it actually send a request to chromium.org?

[morlovich, 2017-02-09 14:05:01]

https://codereview.chromium.org/2686673003/diff/1/net/spdy/spdy_session_fuzze...
File net/spdy/spdy_session_fuzzer.cc (right):

https://codereview.chromium.org/2686673003/diff/1/net/spdy/spdy_session_fuzze...
net/spdy/spdy_session_fuzzer.cc:62: int rv = stream_request.StartRequest(
On 2017/02/09 08:21:01, mmoroz wrote:
> Does it actually send a request to chromium.org?

It shouldn't, as it uses a FuzzedSocketFactory, so it should rather fuzz
failures of the network writes.

[Bence, 2017-02-09 14:11:10]

LGTM with nits, thank you for writing this!

https://codereview.chromium.org/2686673003/diff/1/net/spdy/spdy_session_fuzze...
File net/spdy/spdy_session_fuzzer.cc (right):

https://codereview.chromium.org/2686673003/diff/1/net/spdy/spdy_session_fuzze...
net/spdy/spdy_session_fuzzer.cc:62: int rv = stream_request.StartRequest(
On 2017/02/09 14:05:01, morlovich wrote:
> On 2017/02/09 08:21:01, mmoroz wrote:
> > Does it actually send a request to chromium.org?
> 
> It shouldn't, as it uses a FuzzedSocketFactory, so it should rather fuzz
> failures of the network writes.

Consider using www.example.org or some other reserved name per RFC2606,
regardless of whether the value actually matters.

https://codereview.chromium.org/2686673003/diff/1/net/spdy/spdy_session_fuzze...
net/spdy/spdy_session_fuzzer.cc:71: // re-check the status after potential event
loop.
Nit: Capitalize first letter of sentence.

[Maks Orlovich, 2017-02-10 14:57:48]

The CQ bit was checked by morlovich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 14:58:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Maks Orlovich, 2017-02-10 14:59:17]

https://codereview.chromium.org/2686673003/diff/1/net/spdy/spdy_session_fuzze...
File net/spdy/spdy_session_fuzzer.cc (right):

https://codereview.chromium.org/2686673003/diff/1/net/spdy/spdy_session_fuzze...
net/spdy/spdy_session_fuzzer.cc:62: int rv = stream_request.StartRequest(
On 2017/02/09 14:11:10, Bence (OOO until 02-16) wrote:
> On 2017/02/09 14:05:01, morlovich wrote:
> > On 2017/02/09 08:21:01, mmoroz wrote:
> > > Does it actually send a request to chromium.org?
> > 
> > It shouldn't, as it uses a FuzzedSocketFactory, so it should rather fuzz
> > failures of the network writes.
> 
> Consider using http://www.example.org or some other reserved name per RFC2606,
> regardless of whether the value actually matters.

Went with example.invalid given the original comment, since not resolving seems
like a nice property to have just in case.

https://codereview.chromium.org/2686673003/diff/1/net/spdy/spdy_session_fuzze...
net/spdy/spdy_session_fuzzer.cc:71: // re-check the status after potential event
loop.
On 2017/02/09 14:11:10, Bence (OOO until 02-16) wrote:
> Nit: Capitalize first letter of sentence.

Done.

[commit-bot: I haz the power, 2017-02-10 16:29:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 16:29:31]

Dry run: This issue passed the CQ dry run.

[Maks Orlovich, 2017-02-10 16:47:18]

The CQ bit was checked by morlovich@chromium.org

[Maks Orlovich, 2017-02-10 16:47:18]

The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org
Link to the patchset: https://codereview.chromium.org/2686673003/#ps20001
(title: "Apply review feedback")

[commit-bot: I haz the power, 2017-02-10 16:47:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 16:53:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486745238243340,
"parent_rev": "91697d2c952534944300a1dee86a90d135c736a1", "commit_rev":
"833190ec3fb8c4dd2d66e1b5b2ed3cf34a70f609"}

[commit-bot: I haz the power, 2017-02-10 16:53:43]

Description was changed from

==========
Initial fuzzer for SpdySession

This is pretty limited in what it covers since it doesn't
attempt to request other streams and the like; felt like
the minimum reviewable version.

BUG=688004
==========

to

==========
Initial fuzzer for SpdySession

This is pretty limited in what it covers since it doesn't
attempt to request other streams and the like; felt like
the minimum reviewable version.

BUG=688004

Review-Url: https://codereview.chromium.org/2686673003
Cr-Commit-Position: refs/heads/master@{#449636}
Committed:
https://chromium.googlesource.com/chromium/src/+/833190ec3fb8c4dd2d66e1b5b2ed...
==========

[commit-bot: I haz the power, 2017-02-10 16:53:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/833190ec3fb8c4dd2d66e1b5b2ed...