Selection API: Selection.extend() should throw if rangeCount is 0.

Selection API: Selection.extend() should throw if rangeCount is 0.

Fixes 88 tests in external/wpt/selection/extend-00.html.
The new behavior matches to the standard and Firefox.

* assert_selection.js:
  Prevent load() from throwing an InvalidStateError while running
  editing/deleting/typing_one_character_delete_crash.html

BUG=690240
Review-Url: https://codereview.chromium.org/2686663004
Cr-Commit-Position: refs/heads/master@{#449213}
Committed: https://chromium.googlesource.com/chromium/src/+/de2a69791692ee94fa066dec6bcaf2f2075072c1

[tkent, 2017-02-08 08:49:45]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 08:50:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 10:02:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 10:02:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2017-02-09 00:05:03]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 00:05:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-02-09 00:07:02]

Description was changed from

==========
Selection API: Selection.extend() should throw if rangeCount is 0.

BUG=
==========

to

==========
Selection API: Selection.extend() should throw if rangeCount is 0.

* assert_selection.js:
  Prevent load() from throwing an InvalidStateError while running
  editing/deleting/typing_one_character_delete_crash.html

BUG=
==========

[tkent, 2017-02-09 00:08:04]

Description was changed from

==========
Selection API: Selection.extend() should throw if rangeCount is 0.

* assert_selection.js:
  Prevent load() from throwing an InvalidStateError while running
  editing/deleting/typing_one_character_delete_crash.html

BUG=
==========

to

==========
Selection API: Selection.extend() should throw if rangeCount is 0.

Fixes 88 tests in external/wpt/selection/extend-00.html.

* assert_selection.js:
  Prevent load() from throwing an InvalidStateError while running
  editing/deleting/typing_one_character_delete_crash.html

BUG=
==========

[tkent, 2017-02-09 01:19:53]

Description was changed from

==========
Selection API: Selection.extend() should throw if rangeCount is 0.

Fixes 88 tests in external/wpt/selection/extend-00.html.

* assert_selection.js:
  Prevent load() from throwing an InvalidStateError while running
  editing/deleting/typing_one_character_delete_crash.html

BUG=
==========

to

==========
Selection API: Selection.extend() should throw if rangeCount is 0.

Fixes 88 tests in external/wpt/selection/extend-00.html.

* assert_selection.js:
  Prevent load() from throwing an InvalidStateError while running
  editing/deleting/typing_one_character_delete_crash.html

BUG=690240
==========

[tkent, 2017-02-09 01:21:01]

Description was changed from

==========
Selection API: Selection.extend() should throw if rangeCount is 0.

Fixes 88 tests in external/wpt/selection/extend-00.html.

* assert_selection.js:
  Prevent load() from throwing an InvalidStateError while running
  editing/deleting/typing_one_character_delete_crash.html

BUG=690240
==========

to

==========
Selection API: Selection.extend() should throw if rangeCount is 0.

Fixes 88 tests in external/wpt/selection/extend-00.html.
The new behavior matches to the standard and Firefox.

* assert_selection.js:
  Prevent load() from throwing an InvalidStateError while running
  editing/deleting/typing_one_character_delete_crash.html

BUG=690240
==========

[tkent, 2017-02-09 01:21:40]

tkent@chromium.org changed reviewers:
+ yoichio@chromium.org, yosin@chromium.org

[tkent, 2017-02-09 01:21:40]

yosin@, yoichio@, would you review this please?

[tkent, 2017-02-09 01:23:34]

Patchset #1 (id:1) has been deleted

[yosin_UTC9, 2017-02-09 01:33:18]

https://codereview.chromium.org/2686663004/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/execCommand/transpose-backslash-with-euc.html
(right):

https://codereview.chromium.org/2686663004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/execCommand/transpose-backslash-with-euc.html:14:
backslashDivElement.focus();
I think it is better to write: |getSelection().collapse(backslashDivElement, 0)|
rather than
setting focus to |backslashDivElement| to set selection to backslashDivElement@0
and we
don't need to set focus to content editable for execCommand.

This tells me that we should not set focus by Selection#collapse() and
Selection#extend().

https://codereview.chromium.org/2686663004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2686663004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:368: if (rangeCount() <
1) {
nit: I prefer |rangeCount() == 0| since we |rangeCount()| should be non-negative
integer.
If it returns negative integer, the situation is something wrong and we'll see
disaster
later with using DOMSelection.

[tkent, 2017-02-09 02:05:34]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 02:06:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-02-09 02:06:17]

https://codereview.chromium.org/2686663004/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/execCommand/transpose-backslash-with-euc.html
(right):

https://codereview.chromium.org/2686663004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/execCommand/transpose-backslash-with-euc.html:14:
backslashDivElement.focus();
On 2017/02/09 at 01:33:18, yosin_BlinkOn_slow wrote:
> I think it is better to write: |getSelection().collapse(backslashDivElement,
0)| rather than
> setting focus to |backslashDivElement| to set selection to
backslashDivElement@0 and we
> don't need to set focus to content editable for execCommand.
> 
> This tells me that we should not set focus by Selection#collapse() and
Selection#extend().

Done.

https://codereview.chromium.org/2686663004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2686663004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:368: if (rangeCount() <
1) {
On 2017/02/09 at 01:33:18, yosin_BlinkOn_slow wrote:
> nit: I prefer |rangeCount() == 0| since we |rangeCount()| should be
non-negative integer.
> If it returns negative integer, the situation is something wrong and we'll see
disaster
> later with using DOMSelection.

Done.

[yosin_UTC9, 2017-02-09 02:26:30]

https://codereview.chromium.org/2686663004/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/execCommand/transpose-backslash-with-euc.html
(right):

https://codereview.chromium.org/2686663004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/execCommand/transpose-backslash-with-euc.html:14:
backslashDivElement.focus();
On 2017/02/09 at 01:33:18, yosin_BlinkOn_slow wrote:
> I think it is better to write: |getSelection().collapse(backslashDivElement,
0)| rather than
> setting focus to |backslashDivElement| to set selection to
backslashDivElement@0 and we
> don't need to set focus to content editable for execCommand.
> 
> This tells me that we should not set focus by Selection#collapse() and
Selection#extend().

I filed [1].

http://crbug.com/690272 Selection#collapse,collapseTo{Start,End},extend() should
not move focus

[yosin_UTC9, 2017-02-09 03:41:19]

lgtm

[yosin_UTC9, 2017-02-09 03:41:23]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-02-09 03:41:25]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-09 03:41:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 05:56:30]

CQ is committing da patch.

Bot data: {"patchset_id": 30001, "attempt_start_ts": 1486611685624550,
"parent_rev": "ddc6b690b7d7f2cbd589324329647271772763fd", "commit_rev":
"de2a69791692ee94fa066dec6bcaf2f2075072c1"}

[commit-bot: I haz the power, 2017-02-09 05:57:05]

Description was changed from

==========
Selection API: Selection.extend() should throw if rangeCount is 0.

Fixes 88 tests in external/wpt/selection/extend-00.html.
The new behavior matches to the standard and Firefox.

* assert_selection.js:
  Prevent load() from throwing an InvalidStateError while running
  editing/deleting/typing_one_character_delete_crash.html

BUG=690240
==========

to

==========
Selection API: Selection.extend() should throw if rangeCount is 0.

Fixes 88 tests in external/wpt/selection/extend-00.html.
The new behavior matches to the standard and Firefox.

* assert_selection.js:
  Prevent load() from throwing an InvalidStateError while running
  editing/deleting/typing_one_character_delete_crash.html

BUG=690240

Review-Url: https://codereview.chromium.org/2686663004
Cr-Commit-Position: refs/heads/master@{#449213}
Committed:
https://chromium.googlesource.com/chromium/src/+/de2a69791692ee94fa066dec6bca...
==========

[commit-bot: I haz the power, 2017-02-09 05:57:07]

Committed patchset #2 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/de2a69791692ee94fa066dec6bca...