URL.search should return the set value via setSearch

URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling in DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and calling KURL::setQuery with the given string if it starts
with a question mark and consists of two or more characters.

BUG=682150
Review-Url: https://codereview.chromium.org/2686653003
Cr-Commit-Position: refs/heads/master@{#448940}
Committed: https://chromium.googlesource.com/chromium/src/+/29fc3042b1b3bea3e71a2c5b0a9a81ce435c2d39

[yhirano, 2017-02-08 07:41:46]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 07:42:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-02-08 07:43:38]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 07:43:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-02-08 08:14:38]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 08:14:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-02-08 08:39:21]

Description was changed from

==========
DOM URL query

wip

BUG=682150
==========

to

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition.
DOMURLUtilsReadOnly::search
recovers one question mark and we lose one question mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is equivalent
to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and give other strings starting from a question mark unchanged.



BUG=682150
==========

[yhirano, 2017-02-08 08:40:18]

Description was changed from

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition.
DOMURLUtilsReadOnly::search
recovers one question mark and we lose one question mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is equivalent
to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and give other strings starting from a question mark unchanged.



BUG=682150
==========

to

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is equivalent
to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and give other strings starting from a question mark unchanged.



BUG=682150
==========

[yhirano, 2017-02-08 08:40:50]

Description was changed from

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is equivalent
to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and give other strings starting from a question mark unchanged.



BUG=682150
==========

to

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is
KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and give other strings starting from a question mark unchanged.



BUG=682150
==========

[yhirano, 2017-02-08 08:41:02]

Description was changed from

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is
KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and give other strings starting from a question mark unchanged.



BUG=682150
==========

to

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and give other strings starting from a question mark unchanged.



BUG=682150
==========

[yhirano, 2017-02-08 08:41:35]

Description was changed from

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and give other strings starting from a question mark unchanged.



BUG=682150
==========

to

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and give other strings starting from a question mark unchanged
to KURL::setQuery.



BUG=682150
==========

[yhirano, 2017-02-08 08:47:51]

Description was changed from

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and give other strings starting from a question mark unchanged
to KURL::setQuery.



BUG=682150
==========

to

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and giving other strings starting from a question mark unchanged
to KURL::setQuery.



BUG=682150
==========

[yhirano, 2017-02-08 08:55:26]

yhirano@chromium.org changed reviewers:
+ sigbjornf@opera.com

[yhirano, 2017-02-08 08:55:27]

PTAL

[sof, 2017-02-08 09:02:29]

lgtm

[yhirano, 2017-02-08 09:04:13]

Description was changed from

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and giving other strings starting from a question mark unchanged
to KURL::setQuery.



BUG=682150
==========

to

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and calling KURL::setQuery with the given string if it starts with
a question mark unchanged and consists of two or more characters.

BUG=682150
==========

[yhirano, 2017-02-08 09:04:27]

Description was changed from

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and calling KURL::setQuery with the given string if it starts with
a question mark unchanged and consists of two or more characters.

BUG=682150
==========

to

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and calling KURL::setQuery with the given string if it starts with
a question mark unchanged and consists of two or more characters.

BUG=682150
==========

[yhirano, 2017-02-08 09:04:39]

Description was changed from

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and calling KURL::setQuery with the given string if it starts with
a question mark unchanged and consists of two or more characters.

BUG=682150
==========

to

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and calling KURL::setQuery with the given string if it starts
with a question mark unchanged and consists of two or more characters.

BUG=682150
==========

[yhirano, 2017-02-08 09:04:53]

Description was changed from

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and calling KURL::setQuery with the given string if it starts
with a question mark unchanged and consists of two or more characters.

BUG=682150
==========

to

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and calling KURL::setQuery with the given string if it starts
with a question mark and consists of two or more characters.

BUG=682150
==========

[yhirano, 2017-02-08 09:07:35]

Description was changed from

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and calling KURL::setQuery with the given string if it starts
with a question mark and consists of two or more characters.

BUG=682150
==========

to

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling in DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and calling KURL::setQuery with the given string if it starts
with a question mark and consists of two or more characters.

BUG=682150
==========

[yhirano, 2017-02-08 09:08:21]

The CQ bit was unchecked by yhirano@chromium.org

[yhirano, 2017-02-08 09:08:21]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2017-02-08 09:08:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 10:03:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486544901875780,
"parent_rev": "8c00af2b243ead60e3d7011b5a85367735f19ba1", "commit_rev":
"29fc3042b1b3bea3e71a2c5b0a9a81ce435c2d39"}

[commit-bot: I haz the power, 2017-02-08 10:04:03]

Description was changed from

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling in DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and calling KURL::setQuery with the given string if it starts
with a question mark and consists of two or more characters.

BUG=682150
==========

to

==========
URL.search should return the set value via setSearch

DOMURLUtils and KURL trim off the leading question mark independently, which
leads to trimming off two leading questions in addition. 
DOMURLUtilsReadOnly::search recovers one question mark and we lose one question
mark in total.

The special handling in DOMURLUtils is needed because KURL::setQuery handles
an empty string and a null string differently. KURL::setQuery("?") is
equivalent to KURL::setQuery("") but what we need is KURL::setQuery(String()).

This CL fixes the problem by calling KURL::setQuery(String()) if the given
value is "?", and calling KURL::setQuery with the given string if it starts
with a question mark and consists of two or more characters.

BUG=682150

Review-Url: https://codereview.chromium.org/2686653003
Cr-Commit-Position: refs/heads/master@{#448940}
Committed:
https://chromium.googlesource.com/chromium/src/+/29fc3042b1b3bea3e71a2c5b0a9a...
==========

[commit-bot: I haz the power, 2017-02-08 10:04:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/29fc3042b1b3bea3e71a2c5b0a9a...