[Android Webapps]: Do not resize homescreen icon when not padding the icon

[Android Webapps]: Do not resize homescreen icon when not padding the icon

This CL makes ShortcutHelper#createHomescreenIconFromWebIcon() not do any
resizing when:
- No padding is to be applied
AND
- The icon's size does not exceed
  ActivityManager#getLauncherLargeIconSize() * MAX_INNER_SIZE_RATIO

Resizing an icon to make it slightly larger was making the homescreen blurry.
On top of the resizing done in ShortcutHelper#createHomescreenIconFromWebIcon()
the Android launcher resizes icons if necessary.

BUG=690093
Review-Url: https://codereview.chromium.org/2686623005
Cr-Commit-Position: refs/heads/master@{#449320}
Committed: https://chromium.googlesource.com/chromium/src/+/e10eb740ce96e420b4489f9beb7749b6b35b5e4f

[pkotwicz, 2017-02-08 18:45:24]

Description was changed from

==========
[Android Webapps]: Do not resize homescreen icon when not padding the icon

This CL makes ShortcutHelper#createHomescreenIconFromWebIcon() not do any
resizing when:
- No padding is to be applied
AND
- The icon's size does not exceed
  ActivityManager#getLauncherLargeIconSize() * MAX_INNER_SIZE_RATIO

Resizing an icon to make it slightly larger was making the homescreen icon look
blurry. On top of the resizing done in
ShortcutHelper#createHomescreenIconFromWebIcon() the Android launcher resizes
icons if necessary.

BUG=690093
==========

to

==========
[Android Webapps]: Do not resize homescreen icon when not padding the icon

This CL makes ShortcutHelper#createHomescreenIconFromWebIcon() not do any
resizing when:
- No padding is to be applied
AND
- The icon's size does not exceed
  ActivityManager#getLauncherLargeIconSize() * MAX_INNER_SIZE_RATIO

Resizing an icon to make it slightly larger was making the homescreen blurry.
On top of the resizing done in ShortcutHelper#createHomescreenIconFromWebIcon()
the Android launcher resizes icons if necessary.

BUG=690093
==========

[pkotwicz, 2017-02-08 18:45:24]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[pkotwicz, 2017-02-08 18:45:37]

Xi, can you please take a look?

[Xi Han, 2017-02-08 19:21:59]

lgtm with nits.

https://codereview.chromium.org/2686623005/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
(right):

https://codereview.chromium.org/2686623005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:404: int
outerSize;
Change here to:
int outerSize = innnerSize;

and remove line 414.

[pkotwicz, 2017-02-09 00:46:24]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2017-02-09 00:46:24]

Dominick, can you please take a look?

[dominickn, 2017-02-09 01:01:47]

dominickn@chromium.org changed reviewers:
+ mlamouri@chromium.org

[dominickn, 2017-02-09 01:01:48]

Good catch, lgtm

[pkotwicz, 2017-02-09 01:50:52]

Dominick, should I wait for Mounir's feedback too? (I think you added him as a
reviewer)

[pkotwicz, 2017-02-09 01:50:53]

Dominick, should I wait for Mounir's feedback too? (I think you added him as a
reviewer)

[dominickn, 2017-02-09 01:59:10]

dominickn@chromium.org changed reviewers:
- mlamouri@chromium.org

[dominickn, 2017-02-09 01:59:11]

Oops - meant to CC him as FYI. You can land this, since the only change is that
we don't resize upwards when we previously resized upwards.

[pkotwicz, 2017-02-09 16:16:37]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2017-02-09 16:16:38]

The patchset sent to the CQ was uploaded after l-g-t-m from hanxi@chromium.org
Link to the patchset: https://codereview.chromium.org/2686623005/#ps20001
(title: "Merge branch 'master' into test2")

[commit-bot: I haz the power, 2017-02-09 16:16:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 16:51:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486656997791330,
"parent_rev": "6022be1d30e10c1282502054bb9268f1b78e13c1", "commit_rev":
"e10eb740ce96e420b4489f9beb7749b6b35b5e4f"}

[commit-bot: I haz the power, 2017-02-09 16:51:53]

Description was changed from

==========
[Android Webapps]: Do not resize homescreen icon when not padding the icon

This CL makes ShortcutHelper#createHomescreenIconFromWebIcon() not do any
resizing when:
- No padding is to be applied
AND
- The icon's size does not exceed
  ActivityManager#getLauncherLargeIconSize() * MAX_INNER_SIZE_RATIO

Resizing an icon to make it slightly larger was making the homescreen blurry.
On top of the resizing done in ShortcutHelper#createHomescreenIconFromWebIcon()
the Android launcher resizes icons if necessary.

BUG=690093
==========

to

==========
[Android Webapps]: Do not resize homescreen icon when not padding the icon

This CL makes ShortcutHelper#createHomescreenIconFromWebIcon() not do any
resizing when:
- No padding is to be applied
AND
- The icon's size does not exceed
  ActivityManager#getLauncherLargeIconSize() * MAX_INNER_SIZE_RATIO

Resizing an icon to make it slightly larger was making the homescreen blurry.
On top of the resizing done in ShortcutHelper#createHomescreenIconFromWebIcon()
the Android launcher resizes icons if necessary.

BUG=690093

Review-Url: https://codereview.chromium.org/2686623005
Cr-Commit-Position: refs/heads/master@{#449320}
Committed:
https://chromium.googlesource.com/chromium/src/+/e10eb740ce96e420b4489f9beb77...
==========

[commit-bot: I haz the power, 2017-02-09 16:51:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e10eb740ce96e420b4489f9beb77...