Enable tests in TrayIMETest for MD

Enable tests in TrayIMETest for MD

All three tests in TrayIMETest are skipped in Material Design Ash which
is now the default. Two of the tests would work as-is in MD. The other
one needs some modification as it depends on the IME tray layout.

Also, since a TestApi class is introduced for ImeListView, other tests
that need access to the internals of the ImeListView are also updated.

BUG=685837
TEST=TrayIMETest.*, ImeMenuTrayTest.RefreshImeWithListViewCreated in
     ash_unittests

Review-Url: https://codereview.chromium.org/2686623003
Cr-Commit-Position: refs/heads/master@{#448872}
Committed: https://chromium.googlesource.com/chromium/src/+/096fa853801729da981d17b5346698acb4cca48e

[mohsen, 2017-02-07 19:09:53]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 19:10:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mohsen, 2017-02-07 19:17:29]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 19:17:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mohsen, 2017-02-07 19:17:50]

mohsen@chromium.org changed reviewers:
+ tdanderson@chromium.org

[mohsen, 2017-02-07 19:17:51]

Please take a look...

[commit-bot: I haz the power, 2017-02-07 19:53:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 19:53:31]

Dry run: This issue passed the CQ dry run.

[tdanderson, 2017-02-07 23:27:57]

Thanks for taking the time to dig into these tests! LGTM with one
question/comment.

https://codereview.chromium.org/2686623003/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/ime_menu/ime_list_view.cc (right):

https://codereview.chromium.org/2686623003/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/ime_menu/ime_list_view.cc:467: return
ime_list_view_->keyboard_status_;
Since none of the tests are being run in non-MD anymore (the trybots don't run
them and we are no longer expecting local ToT builds with --ash-md=disabled to
work at all) then I think we should be able to remove lines 464 and 467?

[mohsen, 2017-02-08 02:13:50]

https://codereview.chromium.org/2686623003/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/ime_menu/ime_list_view.cc (right):

https://codereview.chromium.org/2686623003/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/ime_menu/ime_list_view.cc:467: return
ime_list_view_->keyboard_status_;
On 2017/02/07 at 23:27:57, tdanderson wrote:
> Since none of the tests are being run in non-MD anymore (the trybots don't run
them and we are no longer expecting local ToT builds with --ash-md=disabled to
work at all) then I think we should be able to remove lines 464 and 467?

Right. Done.

[mohsen, 2017-02-08 02:13:59]

The CQ bit was checked by mohsen@chromium.org

[mohsen, 2017-02-08 02:13:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2686623003/#ps40001
(title: "Addressed review comments")

[commit-bot: I haz the power, 2017-02-08 02:14:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 02:44:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486520039250790,
"parent_rev": "b556a4992cb17a53683d83d290c4b4736d1727cd", "commit_rev":
"096fa853801729da981d17b5346698acb4cca48e"}

[commit-bot: I haz the power, 2017-02-08 02:45:33]

Description was changed from

==========
Enable tests in TrayIMETest for MD

All three tests in TrayIMETest are skipped in Material Design Ash which
is now the default. Two of the tests would work as-is in MD. The other
one needs some modification as it depends on the IME tray layout.

Also, since a TestApi class is introduced for ImeListView, other tests
that need access to the internals of the ImeListView are also updated.

BUG=685837
TEST=TrayIMETest.*, ImeMenuTrayTest.RefreshImeWithListViewCreated in
     ash_unittests
==========

to

==========
Enable tests in TrayIMETest for MD

All three tests in TrayIMETest are skipped in Material Design Ash which
is now the default. Two of the tests would work as-is in MD. The other
one needs some modification as it depends on the IME tray layout.

Also, since a TestApi class is introduced for ImeListView, other tests
that need access to the internals of the ImeListView are also updated.

BUG=685837
TEST=TrayIMETest.*, ImeMenuTrayTest.RefreshImeWithListViewCreated in
     ash_unittests

Review-Url: https://codereview.chromium.org/2686623003
Cr-Commit-Position: refs/heads/master@{#448872}
Committed:
https://chromium.googlesource.com/chromium/src/+/096fa853801729da981d17b53466...
==========

[commit-bot: I haz the power, 2017-02-08 02:45:43]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/096fa853801729da981d17b53466...