Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Issue 2686623002: PPC/s390: [builtins] Port parameter and argument-related code stubs to CSA (Closed)

Created:
3 years, 10 months ago by JaideepBajwa
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [builtins] Port parameter and argument-related code stubs to CSA Port c205c9b7ea717702d12855d133c05d2a4608abd4 Original Commit Message: Includes the port of these three builtins: FastNewStrictArguments, FastNewSloppyArguments and FastNewRestParameter. Also inline the implementation of these into the corresponding interpreter byte codes. R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5269 LOG=N Review-Url: https://codereview.chromium.org/2686623002 Cr-Commit-Position: refs/heads/master@{#43007} Committed: https://chromium.googlesource.com/v8/v8/+/f6a325fb0111d0ed7ad1846cc1ecc1a71a18448b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1118 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -543 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +0 lines, -531 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 10 months ago (2017-02-07 18:44:33 UTC) #1
john.yan
lgtm
3 years, 10 months ago (2017-02-07 18:45:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686623002/1
3 years, 10 months ago (2017-02-07 18:46:42 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 19:10:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f6a325fb0111d0ed7ad1846cc1ecc1a71a1...

Powered by Google App Engine
This is Rietveld 408576698