Cleanup control_frame_fields_ if coalescer rejected the headers.

Cleanup control_frame_fields_ if coalescer rejected the headers.

Avoids a DCHECK on following frames on the same connection.
Also refactored some tests for BufferedSpdyFramer slightly to avoid
pointless reinterpret_cast back and forth.

BUG=688004
Review-Url: https://codereview.chromium.org/2686613002
Cr-Commit-Position: refs/heads/master@{#448790}
Committed: https://chromium.googlesource.com/chromium/src/+/26140d43a8fd469f8746ba6552192517276652af

[Maks Orlovich, 2017-02-07 18:40:53]

The CQ bit was checked by morlovich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 18:41:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Maks Orlovich, 2017-02-07 18:59:47]

morlovich@chromium.org changed reviewers:
+ bnc@chromium.org

[Maks Orlovich, 2017-02-07 18:59:48]

https://codereview.chromium.org/2686613002/diff/1/net/spdy/buffered_spdy_fram...
File net/spdy/buffered_spdy_framer_unittest.cc (right):

https://codereview.chromium.org/2686613002/diff/1/net/spdy/buffered_spdy_fram...
net/spdy/buffered_spdy_framer_unittest.cc:130: void SimulateInFramer(const
SpdySerializedFrame& frame) {
This could/should arguably be a separate cleanup CL, please let me know if you
would prefer it that way. 

Speaking of other CLs, header_buffer_, header_buffer_valid_, header_stream_id_
in BufferedSpdyFramer all seem dead to me --- worth a cleanup CL?

[commit-bot: I haz the power, 2017-02-07 19:51:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 19:51:45]

Dry run: This issue passed the CQ dry run.

[Bence, 2017-02-07 20:01:17]

LGTM.

https://codereview.chromium.org/2686613002/diff/1/net/spdy/buffered_spdy_fram...
File net/spdy/buffered_spdy_framer_unittest.cc (right):

https://codereview.chromium.org/2686613002/diff/1/net/spdy/buffered_spdy_fram...
net/spdy/buffered_spdy_framer_unittest.cc:130: void SimulateInFramer(const
SpdySerializedFrame& frame) {
On 2017/02/07 18:59:48, morlovich1 wrote:
> This could/should arguably be a separate cleanup CL, please let me know if you
> would prefer it that way. 

I really do not mind doing multiple things in the same CL as long as they are
not too complicated.  So this is okay with me.
 
> Speaking of other CLs, header_buffer_, header_buffer_valid_, header_stream_id_
> in BufferedSpdyFramer all seem dead to me --- worth a cleanup CL?

Totally, yes please!

https://codereview.chromium.org/2686613002/diff/1/net/spdy/buffered_spdy_fram...
net/spdy/buffered_spdy_framer_unittest.cc:132: size_t size = frame.size();
No need for named variable |size| which is only used once two lines below. 
Instead write:
size_t input_remaining = frame.size();

[Maks Orlovich, 2017-02-07 20:39:34]

The CQ bit was checked by morlovich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 20:40:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Maks Orlovich, 2017-02-07 20:40:38]

https://codereview.chromium.org/2686613002/diff/1/net/spdy/buffered_spdy_fram...
File net/spdy/buffered_spdy_framer_unittest.cc (right):

https://codereview.chromium.org/2686613002/diff/1/net/spdy/buffered_spdy_fram...
net/spdy/buffered_spdy_framer_unittest.cc:132: size_t size = frame.size();
On 2017/02/07 20:01:17, Bence wrote:
> No need for named variable |size| which is only used once two lines below. 
> Instead write:
> size_t input_remaining = frame.size();

Done.

[commit-bot: I haz the power, 2017-02-07 22:05:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 22:05:13]

Dry run: This issue passed the CQ dry run.

[Maks Orlovich, 2017-02-07 22:08:05]

The CQ bit was checked by morlovich@chromium.org

[Maks Orlovich, 2017-02-07 22:08:05]

The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org
Link to the patchset: https://codereview.chromium.org/2686613002/#ps20001
(title: "Apply review feedback.")

[commit-bot: I haz the power, 2017-02-07 22:09:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 23:38:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486505285279900,
"parent_rev": "8741905369e3debd9ae7e6eb469fa47a60fbd9b6", "commit_rev":
"26140d43a8fd469f8746ba6552192517276652af"}

[commit-bot: I haz the power, 2017-02-07 23:39:22]

Description was changed from

==========
Cleanup control_frame_fields_ if coalescer rejected the headers.

Avoids a DCHECK on following frames on the same connection.
Also refactored some tests for BufferedSpdyFramer slightly to avoid
pointless reinterpret_cast back and forth.

BUG=688004
==========

to

==========
Cleanup control_frame_fields_ if coalescer rejected the headers.

Avoids a DCHECK on following frames on the same connection.
Also refactored some tests for BufferedSpdyFramer slightly to avoid
pointless reinterpret_cast back and forth.

BUG=688004

Review-Url: https://codereview.chromium.org/2686613002
Cr-Commit-Position: refs/heads/master@{#448790}
Committed:
https://chromium.googlesource.com/chromium/src/+/26140d43a8fd469f8746ba655219...
==========

[commit-bot: I haz the power, 2017-02-07 23:39:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/26140d43a8fd469f8746ba655219...