Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2686583003: Fix line break at element boundary when 8bit element follows 16bit (Closed)

Created:
3 years, 10 months ago by kojii
Modified:
3 years, 10 months ago
Reviewers:
eae
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix line break at element boundary when 8bit element follows 16bit This patch fixes lines to break at element boundaries when 8it element follows 16bit element. BUG=282134, 687659 Review-Url: https://codereview.chromium.org/2686583003 Cr-Commit-Position: refs/heads/master@{#448898} Committed: https://chromium.googlesource.com/chromium/src/+/7e4ae49ae351a0a0146a7fea90550c49a94bf7e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/fast/text/line-break-8bit-after-16bit.html View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/line-break-8bit-after-16bit-expected.html View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextBreakIterator.cpp View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
kojii
PTAL.
3 years, 10 months ago (2017-02-08 00:41:20 UTC) #6
eae
Good catch, thank you. LGTM
3 years, 10 months ago (2017-02-08 00:43:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686583003/1
3 years, 10 months ago (2017-02-08 03:41:27 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 03:46:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e4ae49ae351a0a0146a7fea9055...

Powered by Google App Engine
This is Rietveld 408576698