Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2686583002: [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC. (Closed)

Created:
3 years, 10 months ago by lody
Modified:
3 years, 10 months ago
Reviewers:
stkhapugin, sdefresne
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), mathp+autofillwatch_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC. Automatically generated ARCMigrate commit Notable issues: autofill_client_ios had a variable commented as weak but not actually handled as such. Tried using Weak_NS_Object but it had incorrect behavior wrt autorelease pools. Since the file is only currently included in arc converted targets, __weak was used which functions correctly. BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2686583002 Cr-Commit-Position: refs/heads/master@{#448979} Committed: https://chromium.googlesource.com/chromium/src/+/f1493b26bda043e9e54467c5c1adf22e320a6673

Patch Set 1 #

Patch Set 2 : don't use weaknsobject #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -65 lines) Patch
M ios/chrome/browser/ui/autofill/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_save_card_infobar.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/autofill/card_unmask_prompt_view_bridge.mm View 16 chunks +67 lines, -64 lines 0 comments Download
M ios/chrome/browser/ui/autofill/storage_switch_tooltip.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
lody
Please review. Thanks!
3 years, 10 months ago (2017-02-08 12:26:36 UTC) #11
sdefresne
lgtm
3 years, 10 months ago (2017-02-08 13:25:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686583002/20001
3 years, 10 months ago (2017-02-08 13:27:21 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 13:32:36 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f1493b26bda043e9e54467c5c1ad...

Powered by Google App Engine
This is Rietveld 408576698