Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2686533006: [ObjC ARC] Converts ios/chrome/browser/ui/tabs:unit_tests to ARC. (Closed)

Created:
3 years, 10 months ago by lody
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/tabs:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues: Added __unsafe_unretained annotations. BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2686533006 Cr-Commit-Position: refs/heads/master@{#449613} Committed: https://chromium.googlesource.com/chromium/src/+/afbbf1feb13941a13695d63028c4796bd26c6c4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -21 lines) Patch
M ios/chrome/browser/ui/tabs/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/tabs/tab_strip_controller_unittest.mm View 7 chunks +23 lines, -21 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
lody
Please review, thanks.
3 years, 10 months ago (2017-02-10 09:05:20 UTC) #7
marq (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-10 14:22:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686533006/1
3 years, 10 months ago (2017-02-10 14:25:14 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 14:29:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/afbbf1feb13941a13695d63028c4...

Powered by Google App Engine
This is Rietveld 408576698