Remove type mismatch condition in requestResource

Remove type mismatch condition in requestResource

This CL removes the type matching condition in ResourceFetcher::requestResource()
which shouldn't be hit and replaces it with a CHECK to make sure it is actually never 
hit.

BUG=690632
Review-Url: https://codereview.chromium.org/2686533005
Cr-Commit-Position: refs/heads/master@{#449547}
Committed: https://chromium.googlesource.com/chromium/src/+/25b17c1a107cbc956487b5a6bb4698b986f6f035

[Yoav Weiss, 2017-02-08 22:10:11]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 22:10:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2017-02-08 22:16:30]

Description was changed from

==========
Try to remove type mismatch condition in requestResource

This CL tries to remove a condition which shouldn't be hit and replaces
it with a CHECK to make sure it is actually never hit.

BUG=
==========

to

==========
Remove type mismatch condition in requestResource

This CL removes the type matching condition in
ResourceFetcher::requestResource()
which shouldn't be hit and replaces it with a CHECK to make sure it is actually
never 
hit.

BUG=
==========

[Yoav Weiss, 2017-02-08 22:16:30]

yoav@yoav.ws changed reviewers:
+ csharrison@chromium.org, kinuko@chromium.org

[kinuko, 2017-02-08 22:59:14]

lgtm

[Charlie Harrison, 2017-02-08 23:02:48]

Yoav, do you mind attaching a crbug and referencing it in the code? We should
have it on our radar to change the CHECK to a DCHECK if no crashes occur.

[commit-bot: I haz the power, 2017-02-08 23:52:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 23:52:21]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Yoav Weiss, 2017-02-09 07:39:29]

Looks like the removed check is in fact exercised under several conditions. I'll
dig into it and add appropriate documentation

[Yoav Weiss, 2017-02-09 21:31:35]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 21:32:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2017-02-09 21:39:01]

On 2017/02/09 07:39:29, Yoav Weiss wrote:
> Looks like the removed check is in fact exercised under several conditions.
I'll
> dig into it and add appropriate documentation

So, I discovered why that condition was in place.

Turns out determineRevalidationPolicy was skipping the type check for preloads,
so it got added later down requestResource().
Since that makes little sense, I switched the order of checks in
determineRevalidationPolicy so that mismatched type preloads will `Reload`
rather than `Use`, and removed the condition.

Kinuko, Charlie PTAL?

[Yoav Weiss, 2017-02-09 21:39:15]

Description was changed from

==========
Remove type mismatch condition in requestResource

This CL removes the type matching condition in
ResourceFetcher::requestResource()
which shouldn't be hit and replaces it with a CHECK to make sure it is actually
never 
hit.

BUG=
==========

to

==========
Remove type mismatch condition in requestResource

This CL removes the type matching condition in
ResourceFetcher::requestResource()
which shouldn't be hit and replaces it with a CHECK to make sure it is actually
never 
hit.

BUG=690632
==========

[Charlie Harrison, 2017-02-09 21:44:12]

LGTM, assuming CQ is happy

[commit-bot: I haz the power, 2017-02-09 23:18:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 23:18:49]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-02-10 00:50:37]

Cool!  still LGTM

[Yoav Weiss, 2017-02-10 04:59:28]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2017-02-10 05:00:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 05:05:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486702768826930,
"parent_rev": "769f9a4d6edea0cf066def627d919a65f678fa18", "commit_rev":
"25b17c1a107cbc956487b5a6bb4698b986f6f035"}

[commit-bot: I haz the power, 2017-02-10 05:06:47]

Description was changed from

==========
Remove type mismatch condition in requestResource

This CL removes the type matching condition in
ResourceFetcher::requestResource()
which shouldn't be hit and replaces it with a CHECK to make sure it is actually
never 
hit.

BUG=690632
==========

to

==========
Remove type mismatch condition in requestResource

This CL removes the type matching condition in
ResourceFetcher::requestResource()
which shouldn't be hit and replaces it with a CHECK to make sure it is actually
never 
hit.

BUG=690632

Review-Url: https://codereview.chromium.org/2686533005
Cr-Commit-Position: refs/heads/master@{#449547}
Committed:
https://chromium.googlesource.com/chromium/src/+/25b17c1a107cbc956487b5a6bb46...
==========

[commit-bot: I haz the power, 2017-02-10 05:06:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/25b17c1a107cbc956487b5a6bb46...