In update-test-expectation, skip lines with directories.

In update-test-expectation, skip lines with directories.

BUG=689642
Review-Url: https://codereview.chromium.org/2686523003
Cr-Commit-Position: refs/heads/master@{#448765}
Committed: https://chromium.googlesource.com/chromium/src/+/7c0139fc006f41c79976bbbaf68c6cfd5a55020d

[qyearsley, 2017-02-07 19:52:53]

Description was changed from

==========
In update-test-expectation, skip lines with directories.
==========

to

==========
In update-test-expectation, skip lines with directories.

BUG=689642
==========

[qyearsley, 2017-02-07 19:52:53]

qyearsley@chromium.org changed reviewers:
+ bokan@chromium.org

[bokan, 2017-02-07 20:06:28]

https://codereview.chromium.org/2686523003/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py
(right):

https://codereview.chromium.org/2686523003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py:200:
return [name] != self._port.tests([name])
This will return true for tests files that don't exist or are typo'd. Maybe we
should also check that the path exists on the filesystem?

[qyearsley, 2017-02-07 21:22:38]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[qyearsley, 2017-02-07 21:22:43]

https://codereview.chromium.org/2686523003/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py
(right):

https://codereview.chromium.org/2686523003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py:200:
return [name] != self._port.tests([name])
On 2017/02/07 at 20:06:28, bokan wrote:
> This will return true for tests files that don't exist or are typo'd. Maybe we
should also check that the path exists on the filesystem?

That sounds reasonable. In the latest patch I've now changed this to just
directly check whether the path on the test expectation line is a directory;
does the latest patch look OK?

[commit-bot: I haz the power, 2017-02-07 21:24:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bokan, 2017-02-07 21:28:31]

thanks, lgtm

[qyearsley, 2017-02-07 21:58:17]

The CQ bit was unchecked by qyearsley@chromium.org

[qyearsley, 2017-02-07 21:58:19]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-02-07 21:59:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 22:58:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486504699793930,
"parent_rev": "4ee2eeb27fb5cb49b1d5fa470528c16738d0274d", "commit_rev":
"7c0139fc006f41c79976bbbaf68c6cfd5a55020d"}

[commit-bot: I haz the power, 2017-02-07 22:59:46]

Description was changed from

==========
In update-test-expectation, skip lines with directories.

BUG=689642
==========

to

==========
In update-test-expectation, skip lines with directories.

BUG=689642

Review-Url: https://codereview.chromium.org/2686523003
Cr-Commit-Position: refs/heads/master@{#448765}
Committed:
https://chromium.googlesource.com/chromium/src/+/7c0139fc006f41c79976bbbaf68c...
==========

[commit-bot: I haz the power, 2017-02-07 22:59:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7c0139fc006f41c79976bbbaf68c...