Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 2686513002: [key] Fix for-in with trailing shadowing keys with dict-mode receiver (Closed)

Created:
3 years, 10 months ago by Camillo Bruni
Modified:
3 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[key] Fix for-in with trailing shadowing keys with dict-mode receiver BUG=688307 Review-Url: https://codereview.chromium.org/2686513002 Cr-Commit-Position: refs/heads/master@{#43006} Committed: https://chromium.googlesource.com/v8/v8/+/d0bccc9c6ad5c843dd6d3dff628770f122b6cb63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M src/objects.cc View 2 chunks +2 lines, -1 line 0 comments Download
M test/mjsunit/for-in.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Camillo Bruni
PTAL
3 years, 10 months ago (2017-02-07 10:55:32 UTC) #2
Igor Sheludko
lgtm
3 years, 10 months ago (2017-02-07 17:53:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686513002/1
3 years, 10 months ago (2017-02-07 17:53:46 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 17:55:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d0bccc9c6ad5c843dd6d3dff628770f122b...

Powered by Google App Engine
This is Rietveld 408576698