Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2686503005: Remove SerializedScriptValue::serialize and ScriptValueSerializer::serializeWTFString. (Closed)

Created:
3 years, 10 months ago by jbroman
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, jbroman+watch_chromium.org, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SerializedScriptValue::serialize and ScriptValueSerializer::serializeWTFString. To do so, make WebFrameTest serialize inefficiently (but it's just a unit test) to call postMessage, and have EventSource construct a MessageEvent with a string, rather than serialized script value, as its data. BUG=690132 Review-Url: https://codereview.chromium.org/2686503005 Cr-Commit-Position: refs/heads/master@{#449241} Committed: https://chromium.googlesource.com/chromium/src/+/4f94559a234a15ed12c9244ffee47279f5dca8a5

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Merge branch 'master' into delete-ssv #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -21 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/events/MessageEvent.h View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/MessageEvent.cpp View 1 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/eventsource/EventSource.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 2 3 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
jbroman
3 years, 10 months ago (2017-02-08 22:15:49 UTC) #6
haraken
LGTM
3 years, 10 months ago (2017-02-09 01:04:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686503005/20001
3 years, 10 months ago (2017-02-09 01:07:28 UTC) #11
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-09 01:14:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686503005/40001
3 years, 10 months ago (2017-02-09 02:40:25 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 08:44:30 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4f94559a234a15ed12c9244ffee4...

Powered by Google App Engine
This is Rietveld 408576698