Make ComputedStyle generation deterministic.

Make ComputedStyle generation deterministic.

Since Python dicts are unordered, it is possible that, when we generate
ComputedStyle with no changes to CSSProperties, the generated code is
different (e.g. different order of enum declarations). This is bad
when we start showing diffs for generated code.

This patch enforces an ordering on the generate code so that the
generated code should always be the same given the same input. Namely:

- Enum type declarations are ordered in alphabetical order by name.
- Fields are ordered first by size (for packing), and then in
  alphabetical order by name when there's a tie.

BUG=628043
Review-Url: https://codereview.chromium.org/2686473004
Cr-Commit-Position: refs/heads/master@{#461956}
Committed: https://chromium.googlesource.com/chromium/src/+/fe7b8a3b74de1097ffc1ff819c6b2109dcb6800b

[shend, 2017-02-08 23:27:50]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 23:28:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 23:32:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 23:32:38]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shend, 2017-02-09 21:30:56]

shend@chromium.org changed reviewers:
+ sashab@chromium.org

[shend, 2017-02-09 21:30:57]

Hi Sasha, PTAL

[shend, 2017-02-09 21:31:02]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 21:32:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 23:51:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 23:51:14]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[shend, 2017-02-10 00:13:17]

On 2017/02/09 at 21:30:57, shend wrote:
> Hi Sasha, PTAL

Hmm, lots of tests fail -- we may still have hidden dependencies on enum order

[sashab, 2017-02-10 01:07:12]

Good find. Let's fix these one-by-one. Maybe we can find someone to help you
with this in parallel.

[shend, 2017-02-13 22:46:35]

On 2017/02/10 at 01:07:12, sashab wrote:
> Good find. Let's fix these one-by-one. Maybe we can find someone to help you
with this in parallel.

Culprit was EListStyleType:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/resol...

[sashab, 2017-02-20 00:37:08]

Oh, sweet. That was easy lol. LGTM if there are no more culprits, lets land this
ASAP so it blocks future patches

[shend, 2017-02-28 15:41:33]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 15:41:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 17:08:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 17:08:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shend, 2017-03-01 22:29:56]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 22:30:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 00:50:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 00:50:53]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[shend, 2017-03-13 04:18:59]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 04:19:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 05:52:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 05:52:26]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[shend, 2017-03-14 22:53:09]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 22:53:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 00:27:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 00:27:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shend, 2017-03-28 22:31:36]

Description was changed from

==========
Make ComputedStyle generation deterministic.

Since Python dicts are unordered, it is possible that, when we generate
ComputedStyle with no changes to CSSProperties, the generated code is
different (e.g. different order of enum declarations). This is bad
when we start showing diffs for generated code.

This patch enforces an ordering on the generate code so that the
generated code should always be the same given the same input. Namely:

- Enum declarations are ordered in alphabetical order by name.
- Fields are ordered first by size (for packing), and then in
  alphabetical order by name when there's a tie.

BUG=628043
==========

to

==========
Make ComputedStyle generation deterministic.

Since Python dicts are unordered, it is possible that, when we generate
ComputedStyle with no changes to CSSProperties, the generated code is
different (e.g. different order of enum declarations). This is bad
when we start showing diffs for generated code.

This patch enforces an ordering on the generate code so that the
generated code should always be the same given the same input. Namely:

- Enum type declarations are ordered in alphabetical order by name.
- Fields are ordered first by size (for packing), and then in
  alphabetical order by name when there's a tie.

BUG=628043
==========

[shend, 2017-03-28 22:33:04]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 22:33:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 22:36:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 22:36:29]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shend, 2017-03-28 22:42:59]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 22:43:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 22:57:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 22:57:52]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[shend, 2017-03-29 21:47:42]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 21:48:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 03:54:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 03:54:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shend, 2017-04-04 00:23:15]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 00:23:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 02:02:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 02:02:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shend, 2017-04-04 23:45:20]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 23:45:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 02:46:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 02:46:29]

Dry run: This issue passed the CQ dry run.

[shend, 2017-04-05 02:47:52]

On 2017/02/20 at 00:37:08, sashab wrote:
> Oh, sweet. That was easy lol. LGTM if there are no more culprits, lets land
this ASAP so it blocks future patches

Landing this patch without sorting keywords because they're ordered anyway. This
patch is purely to make code generation deterministic, not to prevent ordering
dependencies.

[shend, 2017-04-05 02:47:55]

The CQ bit was checked by shend@chromium.org

[shend, 2017-04-05 02:47:56]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2686473004/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-05 02:48:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 02:53:29]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491360475669080,
"parent_rev": "0d3b75cb632ce1f29f9888afe995e35caf1a7fe6", "commit_rev":
"fe7b8a3b74de1097ffc1ff819c6b2109dcb6800b"}

[commit-bot: I haz the power, 2017-04-05 02:54:17]

Description was changed from

==========
Make ComputedStyle generation deterministic.

Since Python dicts are unordered, it is possible that, when we generate
ComputedStyle with no changes to CSSProperties, the generated code is
different (e.g. different order of enum declarations). This is bad
when we start showing diffs for generated code.

This patch enforces an ordering on the generate code so that the
generated code should always be the same given the same input. Namely:

- Enum type declarations are ordered in alphabetical order by name.
- Fields are ordered first by size (for packing), and then in
  alphabetical order by name when there's a tie.

BUG=628043
==========

to

==========
Make ComputedStyle generation deterministic.

Since Python dicts are unordered, it is possible that, when we generate
ComputedStyle with no changes to CSSProperties, the generated code is
different (e.g. different order of enum declarations). This is bad
when we start showing diffs for generated code.

This patch enforces an ordering on the generate code so that the
generated code should always be the same given the same input. Namely:

- Enum type declarations are ordered in alphabetical order by name.
- Fields are ordered first by size (for packing), and then in
  alphabetical order by name when there's a tie.

BUG=628043

Review-Url: https://codereview.chromium.org/2686473004
Cr-Commit-Position: refs/heads/master@{#461956}
Committed:
https://chromium.googlesource.com/chromium/src/+/fe7b8a3b74de1097ffc1ff819c6b...
==========

[commit-bot: I haz the power, 2017-04-05 02:54:18]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/fe7b8a3b74de1097ffc1ff819c6b...