Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2686453003: Fix failure of test_runner_test on Windows. (Closed)

Created:
3 years, 10 months ago by Florian Schneider
Modified:
3 years, 10 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix failure of test_runner_test on Windows. test_runner_test does not set up the configuration like a regular test run with test.dart. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/973adc3ea5c917dcfcdd0fab2e936c4cb38e58db

Patch Set 1 #

Patch Set 2 : remove redundancy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M tools/testing/dart/test_runner.dart View 1 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
3 years, 10 months ago (2017-02-07 19:27:37 UTC) #2
zra
lgtm
3 years, 10 months ago (2017-02-07 19:30:26 UTC) #3
Florian Schneider
3 years, 10 months ago (2017-02-07 19:34:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
973adc3ea5c917dcfcdd0fab2e936c4cb38e58db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698