Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 2686453003: Fix failure of test_runner_test on Windows. (Closed)
Patch Set: remove redundancy Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index d9e8d132253ae435c97d3e29f39c16932fd51ab5..06e3b0044ccbca3478285e86d7137b2a32231fb8 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -1914,10 +1914,15 @@ class RunningProcess {
} else if (io.Platform.isWindows) {
bool is_x64 = command.executable.contains("X64") ||
command.executable.contains("SIMARM64");
- executable = configuration['win_sdk_path'] +
- "\\Debuggers\\" + (is_x64 ? "x64" : "x86") + "\\cdb.exe";
- diagnostics.add("Using $executable to print stack traces");
- arguments = ['-p', '${process.pid}', '-c', '!uniqstack;qd'];
+ var win_sdk_path = configuration['win_sdk_path'];
+ if (win_sdk_path != null) {
+ executable = win_sdk_path +
+ "\\Debuggers\\" + (is_x64 ? "x64" : "x86") + "\\cdb.exe";
+ diagnostics.add("Using $executable to print stack traces");
+ arguments = ['-p', '${process.pid}', '-c', '!uniqstack;qd'];
+ } else {
+ diagnostics.add("win_sdk path not found");
+ }
}
if (executable != null) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698