Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2686453002: Refactor useful test helpers to separate files. (Closed)

Created:
3 years, 10 months ago by Alexander Yashkin
Modified:
3 years, 10 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor useful test helpers to separate files. This is another preparational CL for https://codereview.chromium.org/2639153002/. It moves useful helpers for search engines tests to separate test util file. Changes were already reviewed in CL above. R=pkasting@chromium.org Review-Url: https://codereview.chromium.org/2686453002 Cr-Commit-Position: refs/heads/master@{#448576} Committed: https://chromium.googlesource.com/chromium/src/+/b9fede6c510fe9e5f201477263f3ffb5e9fc385a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -46 lines) Patch
M components/search_engines/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M components/search_engines/default_search_manager_unittest.cc View 5 chunks +9 lines, -46 lines 0 comments Download
A components/search_engines/search_engines_test_util.h View 1 chunk +38 lines, -0 lines 0 comments Download
A components/search_engines/search_engines_test_util.cc View 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Alexander Yashkin
3 years, 10 months ago (2017-02-07 07:11:19 UTC) #1
Peter Kasting
LGTM
3 years, 10 months ago (2017-02-07 07:25:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686453002/1
3 years, 10 months ago (2017-02-07 07:39:54 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/304716)
3 years, 10 months ago (2017-02-07 08:25:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686453002/1
3 years, 10 months ago (2017-02-07 09:19:39 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 09:36:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b9fede6c510fe9e5f201477263f3...

Powered by Google App Engine
This is Rietveld 408576698