Move SandboxCompiler class into the sandbox library.

Move SandboxCompiler class into the sandbox library.

This moves the SandboxCompiler class into the isolated sandbox library, as it
only works with the sandbox and does not depend on any Chrome libraries. This
will allow the SandboxCompiler to be re-used in other executables for the v2
sandbox. In addition, it checks in unit tests for the V2 sandbox rules to check
that they are consistently supported across the test bots and OS version.

BUG=689306
Review-Url: https://codereview.chromium.org/2686433002
Cr-Commit-Position: refs/heads/master@{#449117}
Committed: https://chromium.googlesource.com/chromium/src/+/16b6fc55bc0b25e8c64d0bec64ab8ddbf4684a18

[Greg K, 2017-02-07 02:41:58]

The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 02:42:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 02:51:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 02:51:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Greg K, 2017-02-07 03:09:48]

The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 03:10:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Greg K, 2017-02-07 04:24:39]

kerrnel@chromium.org changed reviewers:
+ rsesek@chromium.org

[Greg K, 2017-02-07 04:24:40]

PTAL.

Thanks,

Greg

[Greg K, 2017-02-07 04:31:58]

The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 04:32:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 05:53:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 05:53:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Greg K, 2017-02-07 07:22:20]

The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 07:22:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Greg K, 2017-02-07 07:24:08]

On 2017/02/07 04:24:40, Greg K wrote:
> PTAL.
> 
> Thanks,
> 
> Greg

The test is failing on 10.9 because it lacks (subpath) and (path), but please
review the rest of the CL.

I have fixed the lack of (path on 10.9 by doing:
(define (path x) (literal x))

path and literal behave the same, but path is much more readable, so I want to
keep it and then delete the re-definition once we drop 10.9 support.

The subpath will be more difficult to fix but I am hoping I can do some kind of
transformation into a regular expression, and same thing, once we drop 10.9 we
will use the real subpath.

It would be better to define these variables ONLY for 10.9, but I am not sure
how to conditionally define global variables in scheme. It's usually done by
wrapping everything in a let statement.

[commit-bot: I haz the power, 2017-02-07 08:27:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 08:27:49]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Robert Sesek, 2017-02-07 21:13:39]

https://codereview.chromium.org/2686433002/diff/60001/sandbox/mac/sandbox_mac...
File sandbox/mac/sandbox_mac_compiler_v2_unittest.mm (right):

https://codereview.chromium.org/2686433002/diff/60001/sandbox/mac/sandbox_mac...
sandbox/mac/sandbox_mac_compiler_v2_unittest.mm:62: CHECK(result) << error;
Use ASSERT_TRUE instead of CHECK.

[Greg K, 2017-02-07 22:47:15]

The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 22:48:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 00:08:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 00:08:53]

Dry run: This issue passed the CQ dry run.

[Greg K, 2017-02-08 00:25:44]

https://codereview.chromium.org/2686433002/diff/60001/sandbox/mac/sandbox_mac...
File sandbox/mac/sandbox_mac_compiler_v2_unittest.mm (right):

https://codereview.chromium.org/2686433002/diff/60001/sandbox/mac/sandbox_mac...
sandbox/mac/sandbox_mac_compiler_v2_unittest.mm:62: CHECK(result) << error;
On 2017/02/07 21:13:39, Robert Sesek wrote:
> Use ASSERT_TRUE instead of CHECK.

Unfortunately the ASSERT_* macros don't work in the multiprocess main function,
so I think this has to remain a CHECK().

[Robert Sesek, 2017-02-08 22:25:57]

lgtm

[Greg K, 2017-02-08 22:35:28]

The CQ bit was checked by kerrnel@chromium.org

[commit-bot: I haz the power, 2017-02-08 22:36:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 22:47:45]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486593328327080,
"parent_rev": "cee359ad61a0b36cc22e4214751ae560713dcd6d", "commit_rev":
"16b6fc55bc0b25e8c64d0bec64ab8ddbf4684a18"}

[commit-bot: I haz the power, 2017-02-08 22:48:24]

Description was changed from

==========
Move SandboxCompiler class into the sandbox library.

This moves the SandboxCompiler class into the isolated sandbox library, as it
only works with the sandbox and does not depend on any Chrome libraries. This
will allow the SandboxCompiler to be re-used in other executables for the v2
sandbox. In addition, it checks in unit tests for the V2 sandbox rules to check
that they are consistently supported across the test bots and OS version.

BUG=689306
==========

to

==========
Move SandboxCompiler class into the sandbox library.

This moves the SandboxCompiler class into the isolated sandbox library, as it
only works with the sandbox and does not depend on any Chrome libraries. This
will allow the SandboxCompiler to be re-used in other executables for the v2
sandbox. In addition, it checks in unit tests for the V2 sandbox rules to check
that they are consistently supported across the test bots and OS version.

BUG=689306

Review-Url: https://codereview.chromium.org/2686433002
Cr-Commit-Position: refs/heads/master@{#449117}
Committed:
https://chromium.googlesource.com/chromium/src/+/16b6fc55bc0b25e8c64d0bec64ab...
==========

[commit-bot: I haz the power, 2017-02-08 22:48:25]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/16b6fc55bc0b25e8c64d0bec64ab...