Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2686423002:
MD Settings: improve play store learn more link position (Closed)
|
Created:
3 years, 10 months ago by Dan Beam Modified:
3 years, 10 months ago Reviewers:
tommycli CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: improve play store learn more link position
R=tommycli@chromium.org
BUG=690653
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2686423002
Cr-Commit-Position: refs/heads/master@{#450354}
Committed: https://chromium.googlesource.com/chromium/src/+/b2ebf7e74419122c83624be9d2bddd660572092f
Patch Set 1 #
Total comments: 2
Patch Set 2 : merge #
Messages
Total messages: 21 (13 generated)
Description was changed from ========== MD Settings: fix play store learn more link position R=tommycli@chromium.org BUG=690653 ========== to ========== MD Settings: fix play store learn more link position R=tommycli@chromium.org BUG=690653 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm if my interpretation below is correct https://codereview.chromium.org/2686423002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/android_apps_page/android_apps_page.html (right): https://codereview.chromium.org/2686423002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/android_apps_page/android_apps_page.html:30: class="more-actions" on-tap="stopPropagation_"> stopPropagation i assume is to prevent the link click from triggering the toggle?
https://codereview.chromium.org/2686423002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/android_apps_page/android_apps_page.html (right): https://codereview.chromium.org/2686423002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/android_apps_page/android_apps_page.html:30: class="more-actions" on-tap="stopPropagation_"> On 2017/02/13 16:20:11, tommycli wrote: > stopPropagation i assume is to prevent the link click from triggering the > toggle? yes
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by dbeam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tommycli@chromium.org Link to the patchset: https://codereview.chromium.org/2686423002/#ps20001 (title: "merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== MD Settings: fix play store learn more link position R=tommycli@chromium.org BUG=690653 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: improve play store learn more link position R=tommycli@chromium.org BUG=690653 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...) win_clang on master.tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487080935071630,
"parent_rev": "a231f957275b8be1a1bf97b25acbae7e49328a36", "commit_rev":
"b2ebf7e74419122c83624be9d2bddd660572092f"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: improve play store learn more link position R=tommycli@chromium.org BUG=690653 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: improve play store learn more link position R=tommycli@chromium.org BUG=690653 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2686423002 Cr-Commit-Position: refs/heads/master@{#450354} Committed: https://chromium.googlesource.com/chromium/src/+/b2ebf7e74419122c83624be9d2bd... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/b2ebf7e74419122c83624be9d2bd... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
