Issue 26864005: Revert 215743 "Don't pass /safeseh to the linker when using clan..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26864005: Revert 215743 "Don't pass /safeseh to the linker when using clan..." (Closed)

Created:
7 years, 2 months ago by Reid Kleckner

Modified:
7 years, 2 months ago

Reviewers:
Reid Kleckner, scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 215743 "Don't pass /safeseh to the linker when using clan..." This is no longer needed. Clang is SEH safe because it doesn't support SEH and therefore has no SEH handlers to register in .sxdata. It emits the @feat.00 symbol to let the linker know that it is SEH safe. > Don't pass /safeseh to the linker when using clang on Windows > > It does not generate SEH safe code at the moment. > > R=scottmg@chromium.org > BUG=82385 > > Review URL: https://codereview.chromium.org/21910008 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228004

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	trunk/src/build/common.gypi	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Message was sent while issue was closed.

lgtm