Issue 21910008: Don't pass /safeseh to the linker when using clang on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21910008: Don't pass /safeseh to the linker when using clang on Windows (Closed)

Created:
7 years, 4 months ago by Reid Kleckner

Modified:
7 years, 4 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Visibility:
Public.

Don't pass /safeseh to the linker when using clang on Windows It does not generate SEH safe code at the moment. R=scottmg@chromium.org BUG=82385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215743

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	build/common.gypi	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

scottmg

lgtm are there many like this you think? we might want to put them in ...

7 years, 4 months ago (2013-08-03 00:31:07 UTC) #2

Reid Kleckner

Actually this is the only change to common.gypi that I have, but I like the ...

7 years, 4 months ago (2013-08-03 01:43:32 UTC) #3

Reid Kleckner

7 years, 4 months ago (2013-08-06 00:50:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r215743 (presubmit successful).