Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Issue 2686383002: cros: Use runtime stylus detection for ash palette. (Closed)

Created:
3 years, 10 months ago by jdufault
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

cros: Use runtime stylus detection for ash palette. The same cros image can be used on devices both with and without stylus support. This means we have to use runtime detection for enabling the palette, as we cannot differentiate in the overlay as we do now (USE="stylus"). BUG=679451 Review-Url: https://codereview.chromium.org/2644713002 (cherry picked from commit d08c50b08dfba28fea35212d604fa4619b663724) Review-Url: https://codereview.chromium.org/2686383002 . Cr-Commit-Position: refs/branch-heads/2987@{#457} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/8f066a29781bcb35038eeae2a871ecd5222a0dd0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -137 lines) Patch
M ash/common/ash_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/ash_switches.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/common/palette_delegate.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/common/system/chromeos/palette/palette_tray.h View 4 chunks +6 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/palette/palette_tray.cc View 7 chunks +39 lines, -36 lines 0 comments Download
M ash/common/system/chromeos/palette/palette_utils.h View 2 chunks +6 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/palette/palette_utils.cc View 2 chunks +20 lines, -3 lines 0 comments Download
M ash/common/system/status_area_widget.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ash/common/test/test_palette_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/test/test_palette_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/laser/laser_pointer_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/partial_magnification_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/note_taking_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/note_taking_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.js View 3 chunks +20 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/device_page/device_page.html View 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/resources/settings/device_page/device_page.js View 2 chunks +16 lines, -9 lines 0 comments Download
M chrome/browser/resources/settings/device_page/device_page_browser_proxy.js View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/palette_delegate_chromeos.h View 4 chunks +1 line, -14 lines 0 comments Download
M chrome/browser/ui/ash/palette_delegate_chromeos.cc View 3 chunks +1 line, -21 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/options_stylus_handler.h View 3 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/options_stylus_handler.cc View 4 chunks +25 lines, -3 lines 0 comments Download
A chrome/browser/ui/webui/settings/chromeos/device_stylus_handler.h View 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/settings/chromeos/device_stylus_handler.cc View 1 chunk +120 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/test/data/webui/settings/device_page_tests.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jdufault
3 years, 10 months ago (2017-02-11 00:16:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8f066a29781bcb35038eeae2a871ecd5222a0dd0.

Powered by Google App Engine
This is Rietveld 408576698