mash: Fix shutdown crashes by tearing down ServiceContext before message loop

mash: Fix shutdown crashes by tearing down ServiceContext before message loop

The ui service crashes during shutdown when there isn't a valid message loop.
Tear down the service_manager::ServiceContext before the MessageLoop. Also
change some unique_ptr<> member variables to stack variables to enforce the
correct ordering.

BUG=691061
TEST=chrome --mash, kill ash, ui service shuts down cleanly

Review-Url: https://codereview.chromium.org/2686353002
Cr-Commit-Position: refs/heads/master@{#449741}
Committed: https://chromium.googlesource.com/chromium/src/+/24ff390f92e0b5ac6ad645cd0fd789cb1ab51a94

[James Cook, 2017-02-10 20:49:09]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2017-02-10 20:49:28]

jamescook@chromium.org changed reviewers:
+ erg@chromium.org

[James Cook, 2017-02-10 20:49:28]

erg, please take a look.

[commit-bot: I haz the power, 2017-02-10 20:49:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-02-10 20:51:40]

lgtm

[James Cook, 2017-02-10 20:52:28]

jamescook@chromium.org changed reviewers:
+ rockot@chromium.org

[James Cook, 2017-02-10 20:52:29]

rockot, can I get OWNERS? This is similar to a fix erg@ made recently that you
reviewed.

[Ken Rockot(use gerrit already), 2017-02-10 20:59:03]

lgtm

[James Cook, 2017-02-10 21:16:37]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2017-02-10 21:16:41]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-02-10 21:16:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 21:34:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486761401650950, "parent_rev":
"e6db2dafe177bcc8e3e22612c39b25bead34f01b", "commit_rev":
"24ff390f92e0b5ac6ad645cd0fd789cb1ab51a94"}

[commit-bot: I haz the power, 2017-02-10 21:34:53]

Description was changed from

==========
mash: Fix shutdown crashes by tearing down ServiceContext before message loop

The ui service crashes during shutdown when there isn't a valid message loop.
Tear down the service_manager::ServiceContext before the MessageLoop. Also
change some unique_ptr<> member variables to stack variables to enforce the
correct ordering.

BUG=691061
TEST=chrome --mash, kill ash, ui service shuts down cleanly
==========

to

==========
mash: Fix shutdown crashes by tearing down ServiceContext before message loop

The ui service crashes during shutdown when there isn't a valid message loop.
Tear down the service_manager::ServiceContext before the MessageLoop. Also
change some unique_ptr<> member variables to stack variables to enforce the
correct ordering.

BUG=691061
TEST=chrome --mash, kill ash, ui service shuts down cleanly

Review-Url: https://codereview.chromium.org/2686353002
Cr-Commit-Position: refs/heads/master@{#449741}
Committed:
https://chromium.googlesource.com/chromium/src/+/24ff390f92e0b5ac6ad645cd0fd7...
==========

[commit-bot: I haz the power, 2017-02-10 21:34:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/24ff390f92e0b5ac6ad645cd0fd7...