Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2686323002: Remove temporary expectation from pixel_expectations.py (Closed)

Created:
3 years, 10 months ago by Kai Ninomiya
Modified:
3 years, 10 months ago
Reviewers:
zmo, Zhenyao Mo
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove temporary expectation from pixel_expectations.py Pixel_WebGLTransparentGreenTriangle_NoAlpha_ImplicitClear BUG=666259 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2686323002 Cr-Commit-Position: refs/heads/master@{#449815} Committed: https://chromium.googlesource.com/chromium/src/+/c0e5d3dd86889273b81949ad73f2a0994fbfb4cf

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Kai Ninomiya
PTAL
3 years, 10 months ago (2017-02-10 21:02:57 UTC) #7
Zhenyao Mo
On 2017/02/10 21:02:57, Kai Ninomiya wrote: > PTAL lgtm
3 years, 10 months ago (2017-02-10 21:04:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686323002/1
3 years, 10 months ago (2017-02-10 22:02:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/361981)
3 years, 10 months ago (2017-02-10 22:15:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686323002/20001
3 years, 10 months ago (2017-02-10 23:28:20 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 01:16:47 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c0e5d3dd86889273b81949ad73f2...

Powered by Google App Engine
This is Rietveld 408576698