Issue 26863003: Simplify code for configuring suppression of ImageDecoder warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26863003: Simplify code for configuring suppression of ImageDecoder warnings (Closed)

Created:
7 years, 2 months ago by hal.canary

Modified:
7 years, 2 months ago

Reviewers:
caryclark

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Simplify code for configuring suppression of ImageDecoder warnings For images.png.suppressDecoderWarnings and images.jpeg.suppressDecoderWarnings, the default behavior is now: Debug - DON'T suppress Developer Release - suppress Release - suppress This behavior can be changed in Debug and in Developer through the SkRTConf mechanism. BUG=skia:1680 R=caryclark@google.com Committed: https://code.google.com/p/skia/source/detail?r=11749

Patch Set 1 #

Patch Set 2 : whitespace, lint #

Patch Set 3 : rebased #

Patch Set 4 : rebased again #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -23 lines)			Patch
	M	src/images/SkImageDecoder_libjpeg.cpp	View	1	4 chunks	+8 lines, -10 lines	0 comments	Download
	M	src/images/SkImageDecoder_libpng.cpp	View	1	3 chunks	+11 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scroggo

On 2013/10/10 20:33:16, caryclark wrote: > lgtm I had a bug in the bots that ...

7 years, 2 months ago (2013-10-11 15:59:27 UTC) #3

hal.canary

7 years, 2 months ago (2013-10-14 12:49:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r11749 (presubmit successful).

Expand Messages | Collapse Messages