Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 26824003: Write skimage results to full builder_name. (Closed)

Created:
7 years, 2 months ago by scroggo
Modified:
7 years, 2 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Write skimage results to full builder_name. UploadSKImageResults attempts to upload a folder matching the full builder_name, including _Trybot if the builder is a trybot. (This allows us to see the results of a try.) Fix a bug where run_decoding_tests wrote the results to a folder matching the corresponding waterfall bot (resulting in the upload step not finding anything to upload). This fixes a bug where all trybot runs fail UploadSKImageResults. R=borenet@google.com Committed: https://code.google.com/p/skia/source/detail?r=11729

Patch Set 1 #

Patch Set 2 : Re-upload due to old chunk mismatch error #

Total comments: 2

Patch Set 3 : Respond to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M slave/skia_slave_scripts/run_decoding_tests.py View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scroggo
7 years, 2 months ago (2013-10-11 15:10:28 UTC) #1
borenet
LGTM https://codereview.chromium.org/26824003/diff/3001/slave/skia_slave_scripts/run_decoding_tests.py File slave/skia_slave_scripts/run_decoding_tests.py (right): https://codereview.chromium.org/26824003/diff/3001/slave/skia_slave_scripts/run_decoding_tests.py#newcode32 slave/skia_slave_scripts/run_decoding_tests.py:32: # name. I don't think this new comment ...
7 years, 2 months ago (2013-10-11 15:22:49 UTC) #2
scroggo
https://codereview.chromium.org/26824003/diff/3001/slave/skia_slave_scripts/run_decoding_tests.py File slave/skia_slave_scripts/run_decoding_tests.py (right): https://codereview.chromium.org/26824003/diff/3001/slave/skia_slave_scripts/run_decoding_tests.py#newcode32 slave/skia_slave_scripts/run_decoding_tests.py:32: # name. On 2013/10/11 15:22:49, borenet wrote: > I ...
7 years, 2 months ago (2013-10-11 15:29:44 UTC) #3
scroggo
7 years, 2 months ago (2013-10-11 15:41:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r11729 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698