Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2686253004: Add TEAM/COMPONENT (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org, jam, abarth-chromium, fuzzing_chromium.org, darin-cc_chromium.org, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 Review-Url: https://codereview.chromium.org/2686253004 Cr-Commit-Position: refs/heads/master@{#450457} Committed: https://chromium.googlesource.com/chromium/src/+/8f2127bb83d8c0f9cc421b7c485ea0848d500d3b

Patch Set 1 : Add TEAM/COMPONENT #

Total comments: 14

Patch Set 2 : update team/component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M base/numerics/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ipc/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/ipc_fuzzer/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/security/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-10 22:14:59 UTC) #4
Martin Barbella
Drive-by comments since I saw this on a watchlist and was curious. Tom will still ...
3 years, 10 months ago (2017-02-10 22:28:59 UTC) #6
ymzhang1
On 2017/02/10 22:28:59, Martin Barbella wrote: > Drive-by comments since I saw this on a ...
3 years, 10 months ago (2017-02-10 22:53:53 UTC) #7
Tom Sepez
I added jschuh for input as well. Is there a better way to get a ...
3 years, 10 months ago (2017-02-10 23:17:21 UTC) #9
ymzhang1
On 2017/02/10 23:17:21, Tom Sepez wrote: > I added jschuh for input as well. > ...
3 years, 10 months ago (2017-02-10 23:45:58 UTC) #10
ymzhang1
https://codereview.chromium.org/2686253004/diff/20001/base/numerics/OWNERS File base/numerics/OWNERS (right): https://codereview.chromium.org/2686253004/diff/20001/base/numerics/OWNERS#newcode5 base/numerics/OWNERS:5: # COMPONENT: Blink>Forms>Number On 2017/02/10 23:17:21, Tom Sepez wrote: ...
3 years, 10 months ago (2017-02-14 19:14:29 UTC) #13
Tom Sepez
lgtm
3 years, 10 months ago (2017-02-14 19:20:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686253004/40001
3 years, 10 months ago (2017-02-14 19:21:58 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 20:49:15 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8f2127bb83d8c0f9cc421b7c485e...

Powered by Google App Engine
This is Rietveld 408576698