Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2686253003: [string] Store the correct map during bootstrapping (Closed)

Created:
3 years, 10 months ago by jgruber
Modified:
3 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[string] Store the correct map during bootstrapping This was broken by https://codereview.chromium.org/2663803002. BUG= Review-Url: https://codereview.chromium.org/2686253003 Cr-Commit-Position: refs/heads/master@{#43088} Committed: https://chromium.googlesource.com/v8/v8/+/7ef8cb562a4ecac0f28fe8308412cd14a770064f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/bootstrapper.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jgruber
This didn't end up affecting us on snapshot builds because we store the string map ...
3 years, 10 months ago (2017-02-10 08:22:45 UTC) #4
Yang
On 2017/02/10 08:22:45, jgruber wrote: > This didn't end up affecting us on snapshot builds ...
3 years, 10 months ago (2017-02-10 09:05:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686253003/1
3 years, 10 months ago (2017-02-10 09:36:54 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 09:38:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7ef8cb562a4ecac0f28fe8308412cd14a77...

Powered by Google App Engine
This is Rietveld 408576698