Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2686233008: Unify TypeError messages (Closed)

Created:
3 years, 10 months ago by vabr (Chromium)
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Unify TypeError messages This CL fixes some nits in TypeError messages, unifying the form of kDefineDisallowed and kObjectNotExtensible to match what is used by the majority of the other messages: * "Cannot" vs. "Can't" -> choose "Cannot" * "property:%" -> "property %" * omit the full-stop at the end of the message BUG=v8:5673 Review-Url: https://codereview.chromium.org/2686233008 Cr-Commit-Position: refs/heads/master@{#43150} Committed: https://chromium.googlesource.com/v8/v8/+/e08f85fcfe293a67baf2f7b7d558133ba9d2acba

Patch Set 1 #

Patch Set 2 : Fix test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/messages.h View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/messages.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/webkit/preventExtensions-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
vabr (Chromium)
Hi Hannes, Could you please review this? Cheers, Vaclav
3 years, 10 months ago (2017-02-12 21:05:27 UTC) #10
Hannes Payer (out of office)
lgtm
3 years, 10 months ago (2017-02-13 08:20:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686233008/20001
3 years, 10 months ago (2017-02-13 10:25:29 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 10:27:09 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e08f85fcfe293a67baf2f7b7d558133ba9d...

Powered by Google App Engine
This is Rietveld 408576698