Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2686233004: Mark SwapBuffers for an offscreen surface as unimplemented (Closed)

Created:
3 years, 10 months ago by Geoff Lang
Modified:
3 years, 10 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark SwapBuffers for an offscreen surface as unimplemented BUG=602737 BUG=665521 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2686233004 Cr-Commit-Position: refs/heads/master@{#449866} Committed: https://chromium.googlesource.com/chromium/src/+/ec9b0ca3bf54e11d3e9d206f24845c32e77c5385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Geoff Lang
PTAL
3 years, 10 months ago (2017-02-10 20:43:46 UTC) #5
Zhenyao Mo
On 2017/02/10 20:43:46, Geoff Lang wrote: > PTAL lgtm
3 years, 10 months ago (2017-02-10 21:00:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686233004/1
3 years, 10 months ago (2017-02-11 16:59:56 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 17:07:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ec9b0ca3bf54e11d3e9d206f2484...

Powered by Google App Engine
This is Rietveld 408576698