Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Issue 2686213003: Fix memory leak in SaveToDisk. (Closed)

Created:
3 years, 10 months ago by pink (ping after 24hrs)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix memory leak in SaveToDisk. Fix a memory leak in SaveToDisk by getting rid of the helper function and moving the access to the raw pixels inline. This allows the intermediate CFData object to be correctly refcounted. BUG=685987 TEST=none, test passes Review-Url: https://codereview.chromium.org/2686213003 Cr-Commit-Position: refs/heads/master@{#449723} Committed: https://chromium.googlesource.com/chromium/src/+/0054e56fe7741328be8091e7f620f3a3f76faac9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M ios/chrome/browser/snapshots/snapshot_cache_unittest.mm View 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
rohitrao (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-10 20:25:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686213003/1
3 years, 10 months ago (2017-02-10 20:31:47 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 20:40:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0054e56fe7741328be8091e7f620...

Powered by Google App Engine
This is Rietveld 408576698