Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2686173004: Add validation of sha256 hash formats to ssl_error_assistant proto generator (Closed)

Created:
3 years, 10 months ago by meacer
Modified:
3 years, 10 months ago
Reviewers:
lgarron
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add validation of sha256 hash formats to ssl_error_assistant proto generator BUG=640835 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2686173004 Cr-Commit-Position: refs/heads/master@{#449528} Committed: https://chromium.googlesource.com/chromium/src/+/992f50de218e93808825efbe1067b9968f01fec9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/ssl/ssl_error_assistant/gen_ssl_error_assistant_proto.py View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
meacer
lgarron: PTAL?
3 years, 10 months ago (2017-02-10 01:24:32 UTC) #3
lgarron
lgtm
3 years, 10 months ago (2017-02-10 01:38:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686173004/1
3 years, 10 months ago (2017-02-10 01:42:08 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 02:36:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/992f50de218e93808825efbe1067...

Powered by Google App Engine
This is Rietveld 408576698