EME: Require codecs parameter for audio/videoCapabilities

EME: Require codecs parameter for audio/videoCapabilities

Chrome will no longer allow container-only contentType strings in the
audioCapabilities and videoCapabilities passed to requestMediaKeySystemAccess.
There has been a deprecation message for several releases, so enforce this now.

BUG=605661
TEST=modified tests pass

Review-Url: https://codereview.chromium.org/2686133002
Cr-Commit-Position: refs/heads/master@{#449788}
Committed: https://chromium.googlesource.com/chromium/src/+/2f31b4ce5af50a9ae0b92d484028c41f20db3420

[jrummell, 2017-02-09 18:46:14]

The CQ bit was checked by jrummell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 18:47:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jrummell, 2017-02-09 18:47:25]

jrummell@chromium.org changed reviewers:
+ xhwang@chromium.org

[jrummell, 2017-02-09 18:47:26]

PTAL. Running the trybots to see what other tests I missed.

[commit-bot: I haz the power, 2017-02-09 20:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 20:04:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xhwang, 2017-02-09 20:07:55]

Thanks! Just a few minor comments.

https://codereview.chromium.org/2686133002/diff/1/media/blink/key_system_conf...
File media/blink/key_system_config_selector.cc (right):

https://codereview.chromium.org/2686133002/diff/1/media/blink/key_system_conf...
media/blink/key_system_config_selector.cc:313: // parameters can be rejected.
http://crbug.com/417561
The link is wrong.

Does this TODO still make sense?

https://codereview.chromium.org/2686133002/diff/1/media/blink/key_system_conf...
File media/blink/key_system_config_selector_unittest.cc (right):

https://codereview.chromium.org/2686133002/diff/1/media/blink/key_system_conf...
media/blink/key_system_config_selector_unittest.cc:636:
video_capabilities[1].codecs = kSupportedVideoCodec;
Can we add a test where everything in the capabilities are legit but the codecs
is missing? That capabilities should be supported without this CL, but not
supported now.

https://codereview.chromium.org/2686133002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html
(right):

https://codereview.chromium.org/2686133002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html:88:
}], 'NotSupportedError', 'Basic supported configuration without codecs');
Just in case, add a test where codecs for only audio or video is missing.

[jrummell, 2017-02-09 23:36:08]

Updated.

https://codereview.chromium.org/2686133002/diff/1/media/blink/key_system_conf...
File media/blink/key_system_config_selector.cc (right):

https://codereview.chromium.org/2686133002/diff/1/media/blink/key_system_conf...
media/blink/key_system_config_selector.cc:313: // parameters can be rejected.
http://crbug.com/417561
On 2017/02/09 20:07:55, xhwang_slow wrote:
> The link is wrong.
> 
> Does this TODO still make sense?

Updated link(s). The debate continues on what to do with invalid parameters.

https://codereview.chromium.org/2686133002/diff/1/media/blink/key_system_conf...
File media/blink/key_system_config_selector_unittest.cc (right):

https://codereview.chromium.org/2686133002/diff/1/media/blink/key_system_conf...
media/blink/key_system_config_selector_unittest.cc:636:
video_capabilities[1].codecs = kSupportedVideoCodec;
On 2017/02/09 20:07:55, xhwang_slow wrote:
> Can we add a test where everything in the capabilities are legit but the
codecs
> is missing? That capabilities should be supported without this CL, but not
> supported now.

Done.

https://codereview.chromium.org/2686133002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html
(right):

https://codereview.chromium.org/2686133002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html:88:
}], 'NotSupportedError', 'Basic supported configuration without codecs');
On 2017/02/09 20:07:55, xhwang_slow wrote:
> Just in case, add a test where codecs for only audio or video is missing.

Done. Added both.

[jrummell, 2017-02-09 23:36:10]

The CQ bit was checked by jrummell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 23:36:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2017-02-09 23:52:40]

Thanks! LGTM

[commit-bot: I haz the power, 2017-02-10 02:08:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 02:08:46]

Dry run: This issue passed the CQ dry run.

[jrummell, 2017-02-10 18:53:12]

jrummell@chromium.org changed reviewers:
+ foolip@chromium.org

[jrummell, 2017-02-10 18:53:13]

+foolip@ for OWNERS review of the changes in Deprecation.cpp and UseCounter.h

[foolip, 2017-02-10 23:26:28]

third_party/WebKit lgtm

[jrummell, 2017-02-10 23:30:11]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2017-02-10 23:30:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 23:40:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486769411084860,
"parent_rev": "4be001fc71af06d07cb05c30e4b0665efadefed5", "commit_rev":
"2f31b4ce5af50a9ae0b92d484028c41f20db3420"}

[commit-bot: I haz the power, 2017-02-10 23:41:23]

Description was changed from

==========
EME: Require codecs parameter for audio/videoCapabilities

Chrome will no longer allow container-only contentType strings in the
audioCapabilities and videoCapabilities passed to requestMediaKeySystemAccess.
There has been a deprecation message for several releases, so enforce this now.

BUG=605661
TEST=modified tests pass
==========

to

==========
EME: Require codecs parameter for audio/videoCapabilities

Chrome will no longer allow container-only contentType strings in the
audioCapabilities and videoCapabilities passed to requestMediaKeySystemAccess.
There has been a deprecation message for several releases, so enforce this now.

BUG=605661
TEST=modified tests pass

Review-Url: https://codereview.chromium.org/2686133002
Cr-Commit-Position: refs/heads/master@{#449788}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f31b4ce5af50a9ae0b92d484028...
==========

[commit-bot: I haz the power, 2017-02-10 23:41:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2f31b4ce5af50a9ae0b92d484028...