Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2686123002:
Write GPU integration test arguments to runner output JSON (Closed)
|
Created:
3 years, 10 months ago by oetuaho-nv Modified:
3 years, 10 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWrite GPU integration test arguments to runner output JSON
Having clear idea what configuration generated a particular results
file makes it easier to keep track of things when manually testing
different browser configurations with the test runner.
BUG=690535
TEST=run_gpu_integration_test
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2686123002
Cr-Commit-Position: refs/heads/master@{#451055}
Committed: https://chromium.googlesource.com/chromium/src/+/a48c5ca1a439dc23331804504df789e5b59a93be
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Description was changed from ========== Write GPU integration test arguments to runner output JSON Having clear idea what configuration generated a particular results file makes it easier to keep track of things when manually testing different browser configurations with the test runner. BUG=690535 TEST=run_gpu_integration_test ========== to ========== Write GPU integration test arguments to runner output JSON Having clear idea what configuration generated a particular results file makes it easier to keep track of things when manually testing different browser configurations with the test runner. BUG=690535 TEST=run_gpu_integration_test CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Description was changed from ========== Write GPU integration test arguments to runner output JSON Having clear idea what configuration generated a particular results file makes it easier to keep track of things when manually testing different browser configurations with the test runner. BUG=690535 TEST=run_gpu_integration_test CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Write GPU integration test arguments to runner output JSON Having clear idea what configuration generated a particular results file makes it easier to keep track of things when manually testing different browser configurations with the test runner. BUG=690535 TEST=run_gpu_integration_test CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
oetuaho@nvidia.com changed reviewers: + kbr@chromium.org
Ken, could you take a look at this simple change to the test runner?
Olli, FYI, we're changing the underlying harness which runs these tests from Python's unittest framework to typ in crbug.com/636153 . Once that's done, this code path will probably be deleted, so you'll have to reevaluate it. In the meantime, though, as long as this doesn't break the CQ it's OK.
lgtm
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Do you have an approximate timeline on the runner changes? The reason why I'm proposing these features upstream is to help future maintainability. If the runner is going to completely change without necessarily having complete feature parity we might be better off for the moment by just having a few patches on top of the runner that we maintain ourselves.
On 2017/02/16 17:17:08, oetuaho-nv wrote: > Do you have an approximate timeline on the runner changes? The reason why I'm > proposing these features upstream is to help future maintainability. If the > runner is going to completely change without necessarily having complete feature > parity we might be better off for the moment by just having a few patches on top > of the runner that we maintain ourselves. Please watch http://crbug.com/636153 . There are a couple of newly-discovered blockers that need to be fixed before switching over the harness, but doing so is a priority. Maybe in the next couple of weeks.
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487268232716080, "parent_rev":
"3ab86ccb569cff38b362457b7a12762dc9cbab82", "commit_rev":
"a48c5ca1a439dc23331804504df789e5b59a93be"}
Message was sent while issue was closed.
Description was changed from ========== Write GPU integration test arguments to runner output JSON Having clear idea what configuration generated a particular results file makes it easier to keep track of things when manually testing different browser configurations with the test runner. BUG=690535 TEST=run_gpu_integration_test CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Write GPU integration test arguments to runner output JSON Having clear idea what configuration generated a particular results file makes it easier to keep track of things when manually testing different browser configurations with the test runner. BUG=690535 TEST=run_gpu_integration_test CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2686123002 Cr-Commit-Position: refs/heads/master@{#451055} Committed: https://chromium.googlesource.com/chromium/src/+/a48c5ca1a439dc23331804504df7... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a48c5ca1a439dc23331804504df7... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
