Move metafile printing code from platform canvas to PaintCanvas

Move metafile printing code from platform canvas to PaintCanvas

These functions operate on PaintCanvas and so move them to cc so that
they can continue to work when PaintCanvas is not an SkCanvas.

Additionally, remove skia::GetMetaData which only served to const cast a
pointer that was never const in the first place.  As the underlying
SkCanvas::getMetaData isn't const, this unconstifies the call chains.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2686033005
Cr-Commit-Position: refs/heads/master@{#451073}
Committed: https://chromium.googlesource.com/chromium/src/+/7b64edf3a16518889d4bce514bd4bc0818e5ead2

[enne (OOO), 2017-02-09 22:04:19]

Description was changed from

==========
Move metafile printing code from platform canvas to PaintCanvas

These functions operate on PaintCanvas and so move them to cc so that
they can continue to work when PaintCanvas is not an SkCanvas.

Additionally, remove skia::GetMetaData which only served to const cast a
pointer that was never const in the first place.  As the underlying
SkCanvas::getMetaData isn't const, this unconstifies the call chains.

BUG=671433
==========

to

==========
Move metafile printing code from platform canvas to PaintCanvas

These functions operate on PaintCanvas and so move them to cc so that
they can continue to work when PaintCanvas is not an SkCanvas.

Additionally, remove skia::GetMetaData which only served to const cast a
pointer that was never const in the first place.  As the underlying
SkCanvas::getMetaData isn't const, this unconstifies the call chains.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[enne (OOO), 2017-02-09 22:05:30]

enne@chromium.org changed reviewers:
+ danakj@chromium.org, gene@chromium.org

[danakj, 2017-02-09 23:05:22]

https://codereview.chromium.org/2686033005/diff/1/components/printing/rendere...
File components/printing/renderer/print_web_view_helper.cc (right):

https://codereview.chromium.org/2686033005/diff/1/components/printing/rendere...
components/printing/renderer/print_web_view_helper.cc:1892: SkCanvas* canvas =
metafile->GetVectorCanvasForNewPage(
This is a PaintCanvas right?

https://codereview.chromium.org/2686033005/diff/1/printing/pdf_metafile_skia.cc
File printing/pdf_metafile_skia.cc (right):

https://codereview.chromium.org/2686033005/diff/1/printing/pdf_metafile_skia....
printing/pdf_metafile_skia.cc:172: sk_sp<SkPicture> pic =
data_->recorder_.finishRecordingAsPicture();
PaintRecord record

[danakj, 2017-02-09 23:06:05]

cc LGTM

[enne (OOO), 2017-02-09 23:42:06]

Thanks.  Converted a few more metafile callsites based on compiler yelling.

[enne (OOO), 2017-02-10 22:32:03]

enne@chromium.org changed reviewers:
+ vandebo@chromium.org

[enne (OOO), 2017-02-10 22:33:42]

enne@chromium.org changed reviewers:
+ fmalita@chromium.org, pdr@chromium.org

[enne (OOO), 2017-02-10 22:33:43]

+vandebo as alternate gene for printing owners
+fmalita for skia/ext
+pdr for blink stuff

[enne (OOO), 2017-02-10 22:33:50]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 22:34:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-02-10 22:46:12]

blinky bits lgtm

[commit-bot: I haz the power, 2017-02-10 23:13:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 23:13:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[enne (OOO), 2017-02-10 23:21:05]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 23:21:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 00:25:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 00:25:23]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[vandebo (ex-Chrome), 2017-02-12 04:35:13]

Description was changed from

==========
Move metafile printing code from platform canvas to PaintCanvas

These functions operate on PaintCanvas and so move them to cc so that
they can continue to work when PaintCanvas is not an SkCanvas.

Additionally, remove skia::GetMetaData which only served to const cast a
pointer that was never const in the first place.  As the underlying
SkCanvas::getMetaData isn't const, this unconstifies the call chains.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move metafile printing code from platform canvas to PaintCanvas

These functions operate on PaintCanvas and so move them to cc so that
they can continue to work when PaintCanvas is not an SkCanvas.

Additionally, remove skia::GetMetaData which only served to const cast a
pointer that was never const in the first place.  As the underlying
SkCanvas::getMetaData isn't const, this unconstifies the call chains.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vandebo (ex-Chrome), 2017-02-12 04:35:13]

vandebo@chromium.org changed reviewers:
+ thestig@chromium.org
- vandebo@chromium.org

[vandebo (ex-Chrome), 2017-02-12 04:36:23]

+Lei for printing owners  (I'll be removed shortly) cc: groby in case Lei is
still OOO

[enne (OOO), 2017-02-13 18:49:28]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 18:50:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2017-02-13 18:52:19]

enne@chromium.org changed reviewers:
+ nick@chromium.org

[enne (OOO), 2017-02-13 18:54:38]

+nick for content/renderer changes

I added cc/paint as a general dep here instead of making it mac only (skia/ext
is a public dep which is why this used to work).  I'm happy to make this more
specific if you want, but didn't think it was worth the complication.

[commit-bot: I haz the power, 2017-02-13 19:31:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 19:31:57]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ncarter (slow), 2017-02-13 20:04:47]

content lgtm

[enne (OOO), 2017-02-15 02:07:53]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 02:09:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2017-02-15 02:09:20]

enne@chromium.org changed reviewers:
+ dpapad@chromium.org

[enne (OOO), 2017-02-15 02:09:20]

printing (thestig, gene, dpapad): can one of you review these printing/ changes?
fmalita: ping for skia/ext

[commit-bot: I haz the power, 2017-02-15 04:46:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 04:46:54]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-02-15 18:09:48]

dpapad@chromium.org changed reviewers:
+ vitalybuka@chromium.org
- dpapad@chromium.org

[f(malita), 2017-02-16 14:21:42]

skia/ lgtm

[Vitaly Buka (NO REVIEWS), 2017-02-16 18:11:55]

lgtm

[enne (OOO), 2017-02-16 18:13:54]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2017-02-16 18:13:54]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
pdr@chromium.org, nick@chromium.org
Link to the patchset: https://codereview.chromium.org/2686033005/#ps140001
(title: "Fix missing build_config include")

[commit-bot: I haz the power, 2017-02-16 18:14:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 20:10:13]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1487268834103290,
"parent_rev": "c30c27728fcf046088ca6c0da51bda06e3a5ce63", "commit_rev":
"7b64edf3a16518889d4bce514bd4bc0818e5ead2"}

[commit-bot: I haz the power, 2017-02-16 20:10:58]

Description was changed from

==========
Move metafile printing code from platform canvas to PaintCanvas

These functions operate on PaintCanvas and so move them to cc so that
they can continue to work when PaintCanvas is not an SkCanvas.

Additionally, remove skia::GetMetaData which only served to const cast a
pointer that was never const in the first place.  As the underlying
SkCanvas::getMetaData isn't const, this unconstifies the call chains.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move metafile printing code from platform canvas to PaintCanvas

These functions operate on PaintCanvas and so move them to cc so that
they can continue to work when PaintCanvas is not an SkCanvas.

Additionally, remove skia::GetMetaData which only served to const cast a
pointer that was never const in the first place.  As the underlying
SkCanvas::getMetaData isn't const, this unconstifies the call chains.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2686033005
Cr-Commit-Position: refs/heads/master@{#451073}
Committed:
https://chromium.googlesource.com/chromium/src/+/7b64edf3a16518889d4bce514bd4...
==========

[commit-bot: I haz the power, 2017-02-16 20:11:00]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/7b64edf3a16518889d4bce514bd4...