Simplify SequencedTaskRunner::{Delete,Releaose}Soon impl

Simplify SequencedTaskRunner::{Delete,Releaose}Soon impl

This CL removes SequencedTaskRunner-like type support from DeleteHelper.
There no longer exists such a class, and the removal simplify the
implementation.

TBR=kinuko@chromium.org, shess@chromium.org, asvitkine@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2686033002
Cr-Commit-Position: refs/heads/master@{#449544}
Committed: https://chromium.googlesource.com/chromium/src/+/b9dae93e677cb7d8eaac27575d37bcfdf0d4608b

[tzik, 2017-02-09 05:52:25]

Description was changed from

==========
Simplify SequencedTaskRunner::{Delete,Releaose}Soon impl
==========

to

==========
Simplify SequencedTaskRunner::{Delete,Releaose}Soon impl
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[tzik, 2017-02-09 05:52:39]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 05:53:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-02-09 06:47:35]

Description was changed from

==========
Simplify SequencedTaskRunner::{Delete,Releaose}Soon impl
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Simplify SequencedTaskRunner::{Delete,Releaose}Soon impl

This CL removes SequencedTaskRunner-like type support from DeleteHelper.
There no longer exists such a class, and the removal simplify the
implementation.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2017-02-09 06:47:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 06:47:42]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[tzik, 2017-02-09 07:00:31]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 07:00:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-02-09 07:24:33]

tzik@chromium.org changed reviewers:
+ dcheng@chromium.org

[tzik, 2017-02-09 07:24:34]

PTAL

[commit-bot: I haz the power, 2017-02-09 10:04:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 10:04:10]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-02-09 21:50:17]

https://codereview.chromium.org/2686033002/diff/20001/base/sequenced_task_run...
File base/sequenced_task_runner_helpers.h (right):

https://codereview.chromium.org/2686033002/diff/20001/base/sequenced_task_run...
base/sequenced_task_runner_helpers.h:20: public:
I'd prefer we keep this private if possible (since we lose type-safety with the
void*)

[tzik, 2017-02-09 22:47:00]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 22:47:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-02-09 22:48:13]

https://codereview.chromium.org/2686033002/diff/20001/base/sequenced_task_run...
File base/sequenced_task_runner_helpers.h (right):

https://codereview.chromium.org/2686033002/diff/20001/base/sequenced_task_run...
base/sequenced_task_runner_helpers.h:20: public:
On 2017/02/09 21:50:16, dcheng wrote:
> I'd prefer we keep this private if possible (since we lose type-safety with
the
> void*)

Done.

[dcheng, 2017-02-09 22:49:31]

lgtm

[tzik, 2017-02-09 23:11:44]

Description was changed from

==========
Simplify SequencedTaskRunner::{Delete,Releaose}Soon impl

This CL removes SequencedTaskRunner-like type support from DeleteHelper.
There no longer exists such a class, and the removal simplify the
implementation.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Simplify SequencedTaskRunner::{Delete,Releaose}Soon impl

This CL removes SequencedTaskRunner-like type support from DeleteHelper.
There no longer exists such a class, and the removal simplify the
implementation.

TBR=kinuko@chromium.org, shess@chromium.org, asvitkine@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[tzik, 2017-02-09 23:14:09]

tzik@chromium.org changed reviewers:
+ asvitkine@chromium.org, kinuko@chromium.org, shess@chromium.org

[tzik, 2017-02-09 23:18:02]

TBRing OWNERS, since the diff is simple #include addition.
PTAL later to:
kinuko: //content
shess: //sql
asvitkine: //ui/gfx

[kinuko, 2017-02-10 00:42:12]

(lgtm)

[commit-bot: I haz the power, 2017-02-10 00:44:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 00:44:46]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[tzik, 2017-02-10 02:33:26]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2017-02-10 02:33:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 03:57:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486694006955620,
"parent_rev": "033d9e89ed5ce8b5ee20d7a5d56256c0038fd9f5", "commit_rev":
"b9dae93e677cb7d8eaac27575d37bcfdf0d4608b"}

[commit-bot: I haz the power, 2017-02-10 03:58:14]

Description was changed from

==========
Simplify SequencedTaskRunner::{Delete,Releaose}Soon impl

This CL removes SequencedTaskRunner-like type support from DeleteHelper.
There no longer exists such a class, and the removal simplify the
implementation.

TBR=kinuko@chromium.org, shess@chromium.org, asvitkine@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Simplify SequencedTaskRunner::{Delete,Releaose}Soon impl

This CL removes SequencedTaskRunner-like type support from DeleteHelper.
There no longer exists such a class, and the removal simplify the
implementation.

TBR=kinuko@chromium.org, shess@chromium.org, asvitkine@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2686033002
Cr-Commit-Position: refs/heads/master@{#449544}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9dae93e677cb7d8eaac27575d37...
==========

[commit-bot: I haz the power, 2017-02-10 03:58:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b9dae93e677cb7d8eaac27575d37...

[Scott Hess - ex-Googler, 2017-02-10 06:10:18]

lgtm

[Alexei Svitkine (slow), 2017-02-10 12:31:21]

lgtm