Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2686023003: Use mime type for image extension (Closed)

Created:
3 years, 10 months ago by gambard
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Use mime type for image extension This CL uses the mime type to determine the best image extension when saving an image. BUG=690355 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2686023003 Cr-Commit-Position: refs/branch-heads/2987@{#495} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/cfc7b5297cedfc19b45c9b89930d259c4a864ddd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -30 lines) Patch
M ios/chrome/browser/ui/browser_view_controller.mm View 6 chunks +31 lines, -16 lines 0 comments Download
M ios/web/public/image_fetcher/image_data_fetcher.h View 3 chunks +28 lines, -5 lines 0 comments Download
M ios/web/public/image_fetcher/image_data_fetcher.mm View 4 chunks +22 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
gambard
PTAL. Please not this is for cherry-picking on M57. The API is clearly not the ...
3 years, 10 months ago (2017-02-10 07:51:21 UTC) #2
gambard
On 2017/02/10 07:51:21, gambard wrote: > PTAL. > Please not this is for cherry-picking on ...
3 years, 10 months ago (2017-02-10 08:06:05 UTC) #3
marq (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-10 14:21:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686023003/1
3 years, 10 months ago (2017-02-14 07:29:41 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-02-14 07:29:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686023003/1
3 years, 10 months ago (2017-02-14 07:42:14 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 07:43:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cfc7b5297cedfc19b45c9b89930d...

Powered by Google App Engine
This is Rietveld 408576698