Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 2685943004: Remove TextTrack.regions and VTTRegionList (Closed)

Created:
3 years, 10 months ago by fs
Modified:
3 years, 10 months ago
Reviewers:
foolip
CC:
fs, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove TextTrack.regions and VTTRegionList Removed from the WebVTT spec https://github.com/w3c/webvtt/pull/31 Because we no longer need to track a list of regions in TextTrack, we can also remove all the plumbing between the parser and the (loadable) TextTrack. BUG=690014 Review-Url: https://codereview.chromium.org/2685943004 Cr-Commit-Position: refs/heads/master@{#449791} Committed: https://chromium.googlesource.com/chromium/src/+/f6ca2907e1f31f01920b4d3447030dd47bb8f211

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -280 lines) Patch
M third_party/WebKit/LayoutTests/media/track/regions-webvtt/vtt-region-display.html View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/regions-webvtt/vtt-region-dom-layout.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTrackElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTrackElement.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/LoadableTextTrack.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/LoadableTextTrack.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.h View 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.cpp View 4 chunks +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTParser.h View 4 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp View 7 chunks +2 lines, -23 lines 1 comment Download
D third_party/WebKit/Source/core/html/track/vtt/VTTRegionList.h View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/Source/core/html/track/vtt/VTTRegionList.cpp View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/Source/core/html/track/vtt/VTTRegionList.idl View 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/loader/TextTrackLoader.h View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/TextTrackLoader.cpp View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
fs
3 years, 10 months ago (2017-02-10 10:33:19 UTC) #8
foolip
lgtm https://codereview.chromium.org/2685943004/diff/20001/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp File third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp (right): https://codereview.chromium.org/2685943004/diff/20001/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp#newcode232 third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp:232: if (headerName == "Region") { Yeah, that was ...
3 years, 10 months ago (2017-02-10 23:31:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685943004/20001
3 years, 10 months ago (2017-02-10 23:34:19 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 23:45:23 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f6ca2907e1f31f01920b4d344703...

Powered by Google App Engine
This is Rietveld 408576698