Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2685933004: WebUI: Fix cr-policy-pref-indicator tooltip to pass accessibilty checks. (Closed)

Created:
3 years, 10 months ago by dpapad
Modified:
3 years, 10 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Fix cr-policy-pref-indicator tooltip to pass accessibilty checks. Per https://www.w3.org/TR/wai-aria/roles#tooltip the tooltip should be always referenced by another element via an aria-describedby attribute. This requires the tooltip itself to have an id. The bug was uncovered by running MD Settings tests in Vulcanized mode, but was always there. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2685933004 Cr-Commit-Position: refs/heads/master@{#449233} Committed: https://chromium.googlesource.com/chromium/src/+/bf54c6ba3a28ace58768bd844cc01f1c6601ee25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
dpapad
FYI this bug manifests in a non obvious way (see error below). [4819:4819:0208/190433.788986:ERROR:web_ui_test_handler.cc(76)] Failed: RUN_TEST_F("CrSettingsRouteTest","All") ...
3 years, 10 months ago (2017-02-09 03:05:23 UTC) #5
Dan Beam
lgtm
3 years, 10 months ago (2017-02-09 04:32:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685933004/1
3 years, 10 months ago (2017-02-09 08:01:40 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 08:41:14 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bf54c6ba3a28ace58768bd844cc0...

Powered by Google App Engine
This is Rietveld 408576698