Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2685933003: memory coordinator: Call PurgeMemory() after Notify(SUSPENDED) (Closed)

Created:
3 years, 10 months ago by bashi
Modified:
3 years, 10 months ago
Reviewers:
haraken, tasak
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

memory coordinator: Call PurgeMemory() after Notify(SUSPENDED) Currently we tentatively call PurgeMemory() before Notify(SUSPENDED). The order should be reversed as there could be cache allocations before suspending (throttling) task is actually done, as Eric mentioned[1]. [1] https://codereview.chromium.org/2664703002/#msg15 BUG=684287 Review-Url: https://codereview.chromium.org/2685933003 Cr-Commit-Position: refs/heads/master@{#449189} Committed: https://chromium.googlesource.com/chromium/src/+/a8c0d87fb51b053a25e3cebfde5ccbd94a24f10c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/child/memory/child_memory_coordinator_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
bashi
PTAL I'll remove Notify() call after https://codereview.chromium.org/2664703002/ is landed anyway, so this might not be ...
3 years, 10 months ago (2017-02-09 01:59:27 UTC) #6
haraken
LGTM
3 years, 10 months ago (2017-02-09 02:02:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685933003/1
3 years, 10 months ago (2017-02-09 02:04:39 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 02:12:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a8c0d87fb51b053a25e3cebfde5c...

Powered by Google App Engine
This is Rietveld 408576698