Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2685893004: Reland Re-enable fetching component policies for login screen apps (Closed)

Created:
3 years, 10 months ago by emaxx
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland Re-enable fetching component policies for login screen apps This CL relands enabling fetching of policies for Chrome OS login screen apps. The originally landed code was temporarily disabled due to DMServer responding with errors when an unknown policy type was requested. Now this can be enabled back, after the DMServer got fixed to at least ignore the new policy type (until it starts to actually provide policies with this type). TBR=tnagel@chromium.org BUG=644304, 666720 TEST=re-enabled browser tests; manual test: sign into an enrolled device, go to chrome://policy and check that the device policies were fetched successfully Review-Url: https://codereview.chromium.org/2685893004 Cr-Commit-Position: refs/heads/master@{#449157} Committed: https://chromium.googlesource.com/chromium/src/+/94c4e6b642d971a31680fbb19858f56e1a4d8d7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -38 lines) Patch
M chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc View 7 chunks +23 lines, -25 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h View 2 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (8 generated)
emaxx
Just TBR'ed reviewers (tnagel@) as the CL is absolutely the same as the previously landed. ...
3 years, 10 months ago (2017-02-09 00:13:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685893004/1
3 years, 10 months ago (2017-02-09 00:14:24 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 00:20:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/94c4e6b642d971a31680fbb19858...

Powered by Google App Engine
This is Rietveld 408576698